Heads up -- Shot Quality only tracking shots on goal, not shot attempts

TobyInHR · 02-17-2023, 07:01 PM

This may be a known issue with the shot quality stats that were just added, but looking through some CSVs with the new data, it appears as though only shots on goal are counted, which means the penalty applied to blocked shots is not factored in.

To illustrate this: I'm looking at a game where the home team had 29 shots on goal. Their quality numbers are 10-8-8-3-0. But the away team players have been credited with 7 blocked shots, which means the quality stat is looking only at shots the goalie saved, rather than all shot attempts.

I'm not sure if this is intentional, but I'm guessing the intent is to record shots on goal and shots that *could* have been on goal, but never reached the net to find out, as opposed to all shot attempts (since a missed shot could never be a goal).

Just wanted to point it out! Thanks again for adding more advanced stats guys! I'm super excited to mess around with them. Can't wait for shot quality to start showing up in player stats.

JeffR · 02-18-2023, 04:11 AM

That's in 2D-played games, right? It's supposed to be shot attempts; Sebastian just fixed that this morning for classic mode, he must've missed it in the other one. Doing a bunch of work on that today, we'll get that done as well.

Any other issues with the new csv stuff so far? We're pretty close to getting shot locations mapped but are still dealing with some problems (conversion from the old engine being the main issue, that's a bit janky now); if it's not in this update it should be in the final one.

TobyInHR · 02-18-2023, 11:49 AM

Quote:

Originally Posted by JeffR

That's in 2D-played games, right? It's supposed to be shot attempts; Sebastian just fixed that this morning for classic mode, he must've missed it in the other one. Doing a bunch of work on that today, we'll get that done as well.

Any other issues with the new csv stuff so far? We're pretty close to getting shot locations mapped but are still dealing with some problems (conversion from the old engine being the main issue, that's a bit janky now); if it's not in this update it should be in the final one.

Correct, I have my game set to 2D for all leagues. Will the team stats include SOG, MS, and BS for teams then? Or just SOG and quality 0-4? I'm so excited to have this in the game, just so you know. Like, I spent the whole day at work sketching ideas down for what can be done with these stats lol.

I haven't noticed any other issues in the CSV data! The only thing I can think of is that games that were simulated prior to the beta build default to all shots being SQ0, but that makes sense and probably isn't worth losing sleep over. Any idea if/when shot quality will get added to the player stats? Having it for the teams is great because I can get xG for each team, which allows me to do team-adjusted conversions, but having it for players will be game-changing.

I haven't dug into the contracts or player ratings too much. I plan on putting together a WAR Value stat, basically the $$ per win value of a player, so I can look into that today and let ya know if I come across any issues.

JeffR · 02-19-2023, 05:41 AM

I thought BS was already in there as well, but apparently not, probably just an oversight; I'll see if we can get that in. Missed shots could be inferred from totalling the shot quality numbers and subtracting the SOG, so I'm not sure we need to include that separately.

Yeah, no way to fix the SQ stats from games run in older versions, most of the data's just not there since it's only created in new games.

TobyInHR · 02-19-2023, 03:27 PM

Agreed on the calculation to find missed shots -- I think it's better to exclude redundant information than include it for the sake of consistency.

Not sure what is going on with the Contracts CSV, but Average Salary seems to be displaying the AAV in a different amount than dollars? For example, Cam Atkinson is on my team with a one-year, $5.275m contract, but the CSV says his average salary is $26,375,000. Couturier has an average salary of $10,333,334 in the CSV, actual contract is $7.750m over 6 years.

JeffR · 02-20-2023, 02:49 AM

I think Sebastian's going to put in total shot attempts, so that'll make it a little easier.

Yeah, something looks off with the average salary. I'm getting different numbers for Atkinson at the start of a new game, but it's definitely off. I think the issue may be with the data not being there for his whole contract (i.e. the one started in 2018-19) so it may only happen with older contracts at the start of the game, but I'll see if we can fix that.

TobyInHR · 02-20-2023, 01:32 PM

Quote:

Originally Posted by JeffR

I think Sebastian's going to put in total shot attempts, so that'll make it a little easier.

Yeah, something looks off with the average salary. I'm getting different numbers for Atkinson at the start of a new game, but it's definitely off. I think the issue may be with the data not being there for his whole contract (i.e. the one started in 2018-19) so it may only happen with older contracts at the start of the game, but I'll see if we can fix that.

Average salary seems to be summing a few different values, as opposed to just taking the average. You can see here, player 23 has his contract value summed, but player 35 has an AAV of $750k, listed average salary at $1.125m.

02-17-2023, 07:01 PM	#1
TobyInHR Minors (Rookie Ball) Join Date: Oct 2022 Posts: 30	Heads up -- Shot Quality only tracking shots on goal, not shot attempts This may be a known issue with the shot quality stats that were just added, but looking through some CSVs with the new data, it appears as though only shots on goal are counted, which means the penalty applied to blocked shots is not factored in. To illustrate this: I'm looking at a game where the home team had 29 shots on goal. Their quality numbers are 10-8-8-3-0. But the away team players have been credited with 7 blocked shots, which means the quality stat is looking only at shots the goalie saved, rather than all shot attempts. I'm not sure if this is intentional, but I'm guessing the intent is to record shots on goal and shots that could have been on goal, but never reached the net to find out, as opposed to all shot attempts (since a missed shot could never be a goal). Just wanted to point it out! Thanks again for adding more advanced stats guys! I'm super excited to mess around with them. Can't wait for shot quality to start showing up in player stats.

02-19-2023, 03:27 PM	#5
TobyInHR Minors (Rookie Ball) Join Date: Oct 2022 Posts: 30	Agreed on the calculation to find missed shots -- I think it's better to exclude redundant information than include it for the sake of consistency. Not sure what is going on with the Contracts CSV, but Average Salary seems to be displaying the AAV in a different amount than dollars? For example, Cam Atkinson is on my team with a one-year, $5.275m contract, but the CSV says his average salary is $26,375,000. Couturier has an average salary of $10,333,334 in the CSV, actual contract is $7.750m over 6 years. Last edited by TobyInHR; 02-19-2023 at 03:47 PM.

02-18-2023, 04:11 AM	#2
JeffR FHM Producer Join Date: Apr 2002 Location: Kelowna, BC Posts: 17,426	That's in 2D-played games, right? It's supposed to be shot attempts; Sebastian just fixed that this morning for classic mode, he must've missed it in the other one. Doing a bunch of work on that today, we'll get that done as well. Any other issues with the new csv stuff so far? We're pretty close to getting shot locations mapped but are still dealing with some problems (conversion from the old engine being the main issue, that's a bit janky now); if it's not in this update it should be in the final one.

02-19-2023, 05:41 AM	#4
JeffR FHM Producer Join Date: Apr 2002 Location: Kelowna, BC Posts: 17,426	I thought BS was already in there as well, but apparently not, probably just an oversight; I'll see if we can get that in. Missed shots could be inferred from totalling the shot quality numbers and subtracting the SOG, so I'm not sure we need to include that separately. Yeah, no way to fix the SQ stats from games run in older versions, most of the data's just not there since it's only created in new games.

02-20-2023, 02:49 AM	#6
JeffR FHM Producer Join Date: Apr 2002 Location: Kelowna, BC Posts: 17,426	I think Sebastian's going to put in total shot attempts, so that'll make it a little easier. Yeah, something looks off with the average salary. I'm getting different numbers for Atkinson at the start of a new game, but it's definitely off. I think the issue may be with the data not being there for his whole contract (i.e. the one started in 2018-19) so it may only happen with older contracts at the start of the game, but I'll see if we can fix that.