PLG's running utility discussion - Page 2

sporr · 07-16-2004, 11:48 AM

Pierre,

Is there any way to pull out the debut year for a player? The only two items that we really need to correct Pro Service time is debut year and current year.

kq76 · 07-16-2004, 12:46 PM

Quote:

Originally Posted by PLG

I updated the career editor.

http://www.ootpdevelopments.com/boar...639#post782639

Thanks very much Pierre!

For anyone interested, I started a new thread on suggestions for how to edit service time at: http://www.ootpdevelopments.com/boar...837#post783837

PLG · 07-16-2004, 01:01 PM

Quote:

Originally Posted by sporr

Pierre,

Is there any way to pull out the debut year for a player? The only two items that we really need to correct Pro Service time is debut year and current year.

The only debut year I can read is the first year of the career stat stored in the game.

sporr · 07-16-2004, 01:12 PM

Quote:

Originally Posted by PLG

The only debut year I can read is the first year of the career stat stored in the game.

That first year is a player's first year of MLB stats, not minor league stats, correct?

kq76 · 07-16-2004, 03:22 PM

Is there a way you can read the year in the first line of the corresponding p####.txt file? That has the year they were drafted.

PLG · 07-16-2004, 03:26 PM

Quote:

Originally Posted by sporr

That first year is a player's first year of MLB stats, not minor league stats, correct?

I think it is possible to retreive the first year in minor (if the player has stats) and retreive the first year im the major.

For reading a text file, I don not want to go in that kind of file, this is too easy to change it than screw up a program.

sporr · 07-16-2004, 05:34 PM

Quote:

Originally Posted by PLG

I think it is possible to retreive the first year in minor (if the player has stats) and retreive the first year im the major.

For reading a text file, I don not want to go in that kind of file, this is too easy to change it than screw up a program.

Alright, then we would need something like this (in programming language of course):

X = 1st year (overall) of player stats
Y = 1st year of minor stats
Z = 1st year of major stats
W = Current league year

If Y=<Z then X=Y
If Y>Z then X=Z

W-X = Player's Years of Pro Service

That would at least solve that half of the Service time problem. MLB Service Time would be a more difficult nut to crack.

PLG · 07-17-2004, 07:21 PM

Quote:

Originally Posted by sporr

Alright, then we would need something like this (in programming language of course):

X = 1st year (overall) of player stats
Y = 1st year of minor stats
Z = 1st year of major stats
W = Current league year

If Y=<Z X="Y</p" then> If Y>Z then X=Z

W-X = Player's Years of Pro Service

That would at least solve that half of the Service time problem. MLB Service Time would be a more difficult nut to crack.

Ok, I will update my small utility to perform this calc monday. Dont forget that my small utility will show you the result one player at time. Than a future one-shot will affect all players.

sporr · 07-18-2004, 12:19 AM

Not sure why the formula line is showing up strange, but here is how it should read:

X = 1st year (overall) of player stats
Y = 1st year of minor stats
Z = 1st year of major stats
W = Current league year

If Y (less than ) Z then X=Y
If Y>Z then X=Z
If Y=Z then X=Y

W-X = Player's Years of Pro Service

PLG · 07-19-2004, 08:37 AM

Ok, I think we are not very far to find a solution.

I added 2 other information

The career years and the minor years. Now, some players start their
career in 1999 for example and they have stat in the minor in 2002.
Not sure what we can do about this

the updated utility is at http://www.liguemtl.com/download/PYear.zip

Let me know guys.

Thanks

sporr · 07-19-2004, 11:16 AM

Alright, all of the info that we need for correct Pro Service Years is there, we just need to pull the right formula.

Here are the only elements that we need, and all of them can be found in your new utility:
Career Batting = CB
Career Pitching = CP
Minor Batting = MB
Minor Pitching = MP
1st Pro Year = PY
Current Year = CY

First, we need the program to take the lowest year listed in CB, CP, MB, or MP. This is PY regardless of which of the four "boxes" it's in.

Then, CY - PY = Years of Pro Service

Pretty simple I think. It will only be inaccurate for players that spent a full season in FA after their pro time began. But this is a very small % of players. Let me know if you need any other info Pierre, and thanks again!

PLG · 07-19-2004, 01:04 PM

Quote:

Originally Posted by sporr

Alright, all of the info that we need for correct Pro Service Years is there, we just need to pull the right formula.

Here are the only elements that we need, and all of them can be found in your new utility:
Career Batting = CB
Career Pitching = CP
Minor Batting = MB
Minor Pitching = MP
1st Pro Year = PY
Current Year = CY

First, we need the program to take the lowest year listed in CB, CP, MB, or MP. This is PY regardless of which of the four "boxes" it's in.

Then, CY - PY = Years of Pro Service

Pretty simple I think. It will only be inaccurate for players that spent a full season in FA after their pro time began. But this is a very small % of players. Let me know if you need any other info Pierre, and thanks again!

Ok, Done

Now I think we need to take a look at the number of days to make sure to reflect correctly the new number of years. Take a look now.

http://www.liguemtl.com/download/PYear.zip

PLG · 07-19-2004, 01:05 PM

Do you have a MSN account ?

sporr · 07-19-2004, 01:17 PM

No I don't. I'll take a look at the utility in a bit and let you know how it is.

sporr · 07-19-2004, 01:28 PM

Pierre,

That utility listed it perfectly! Every player that I checked had the correct Pro Service Time. That will solve half of the problem for converted leagues. The MLB Service Years will likely be a little more difficult to nail down since accurate playing time wasn't tracked in prior versions. I think kq was working on some kind of formula.

But Pro Service was the biggy for me and this looks like it's been calculated perfectly. So, I assume that when you finalize the utility you will just run it once on the league and it will correct all Pro Service Years, correct?

PLG · 07-19-2004, 01:37 PM

Yes, this will update all players but now, do we have to recalculate the
"Days of service" this way ?

Number of ProYear * 172 (in that case)

Cause I think if we change the number of years only, OOTP will recalculates it and will put back the original value.

sporr · 07-19-2004, 01:39 PM

Quote:

Originally Posted by PLG

Yes, this will update all players but now, do we have to recalculate the
"Days of service" this way ?

Number of ProYear * 172 (in that case)

No, not in this case. Days of service is important for "MLB Service Time", but is not relevant for "Pro Service Time". This utility will correct the Pro Service Years, but the MLB Service Years will still need to be fixed at a later date.

PLG · 07-19-2004, 01:55 PM

Quote:

Originally Posted by sporr

No, not in this case. Days of service is important for "MLB Service Time", but is not relevant for "Pro Service Time". This utility will correct the Pro Service Years, but the MLB Service Years will still need to be fixed at a later date.

Ok, go d/l the utility here
http://www.liguemtl.com/download/PYearu.zip

I added a button to update all players. Make a backup of your players.dat file
only than run the utility.

Let me know

PLG · 07-19-2004, 01:57 PM

Than for the rest, I will wait for kq.

Treches · 07-19-2004, 02:37 PM

Great work, Pierre. This will help leagues transferring to V6 a great deal.

07-16-2004, 03:22 PM	#25
kq76 Global Moderator Join Date: Nov 2002 Posts: 12,101	Is there a way you can read the year in the first line of the corresponding p####.txt file? That has the year they were drafted. __________________ My OOTP Wishlist \| My FAQ List OOTP Wiki \| Your Recommended Team Nicknames, By City (A Crowdsourced Project) For Beta/Devs: Full screen (1920x1080)

07-19-2004, 08:37 AM	#30
PLG All Star Reserve Join Date: Dec 2001 Location: Montréal, Canada Posts: 640	Ok, I think we are not very far to find a solution. I added 2 other information The career years and the minor years. Now, some players start their career in 1999 for example and they have stat in the minor in 2002. Not sure what we can do about this the updated utility is at http://www.liguemtl.com/download/PYear.zip Let me know guys. Thanks __________________ Pierre pierrepage30@hotmail.com If it's tourist season, why can't we shoot them?

07-19-2004, 01:05 PM	#33
PLG All Star Reserve Join Date: Dec 2001 Location: Montréal, Canada Posts: 640	Do you have a MSN account ? __________________ Pierre pierrepage30@hotmail.com If it's tourist season, why can't we shoot them?

07-19-2004, 01:37 PM	#36
PLG All Star Reserve Join Date: Dec 2001 Location: Montréal, Canada Posts: 640	Yes, this will update all players but now, do we have to recalculate the "Days of service" this way ? Number of ProYear * 172 (in that case) Cause I think if we change the number of years only, OOTP will recalculates it and will put back the original value. __________________ Pierre pierrepage30@hotmail.com If it's tourist season, why can't we shoot them?

07-19-2004, 01:57 PM	#39
PLG All Star Reserve Join Date: Dec 2001 Location: Montréal, Canada Posts: 640	Than for the rest, I will wait for kq. __________________ Pierre pierrepage30@hotmail.com If it's tourist season, why can't we shoot them?

07-16-2004, 11:48 AM	#21
sporr Global Moderator Join Date: Dec 2001 Location: Muscatine, IA Posts: 8,277	Pierre, Is there any way to pull out the debut year for a player? The only two items that we really need to correct Pro Service time is debut year and current year.

07-18-2004, 12:19 AM	#29
sporr Global Moderator Join Date: Dec 2001 Location: Muscatine, IA Posts: 8,277	Not sure why the formula line is showing up strange, but here is how it should read: X = 1st year (overall) of player stats Y = 1st year of minor stats Z = 1st year of major stats W = Current league year If Y (less than ) Z then X=Y If Y>Z then X=Z If Y=Z then X=Y W-X = Player's Years of Pro Service

07-19-2004, 11:16 AM	#31
sporr Global Moderator Join Date: Dec 2001 Location: Muscatine, IA Posts: 8,277	Alright, all of the info that we need for correct Pro Service Years is there, we just need to pull the right formula. Here are the only elements that we need, and all of them can be found in your new utility: Career Batting = CB Career Pitching = CP Minor Batting = MB Minor Pitching = MP 1st Pro Year = PY Current Year = CY First, we need the program to take the lowest year listed in CB, CP, MB, or MP. This is PY regardless of which of the four "boxes" it's in. Then, CY - PY = Years of Pro Service Pretty simple I think. It will only be inaccurate for players that spent a full season in FA after their pro time began. But this is a very small % of players. Let me know if you need any other info Pierre, and thanks again!

07-19-2004, 01:17 PM	#34
sporr Global Moderator Join Date: Dec 2001 Location: Muscatine, IA Posts: 8,277	No I don't. I'll take a look at the utility in a bit and let you know how it is.

07-19-2004, 01:28 PM	#35
sporr Global Moderator Join Date: Dec 2001 Location: Muscatine, IA Posts: 8,277	Pierre, That utility listed it perfectly! Every player that I checked had the correct Pro Service Time. That will solve half of the problem for converted leagues. The MLB Service Years will likely be a little more difficult to nail down since accurate playing time wasn't tracked in prior versions. I think kq was working on some kind of formula. But Pro Service was the biggy for me and this looks like it's been calculated perfectly. So, I assume that when you finalize the utility you will just run it once on the league and it will correct all Pro Service Years, correct?

07-19-2004, 02:37 PM	#40
Treches Hall Of Famer Join Date: Dec 2001 Location: Damned Hell Posts: 2,150	Great work, Pierre. This will help leagues transferring to V6 a great deal. __________________ The Computer Baseball League