Regional Tournament of Nation Includes Out of Region Nations

FleetWalker · 09-16-2023, 01:28 PM

I think this is a bug. I created a tournament for nations that has a specified region. I'm assuming what happens if that game first looks to see what players are from eligible nations in the region then chooses nations based on available talent. That's fine, except that it is picking from nations NOT in the region.

How can this happen? In my world, all the players from one nation that is out of the region also have a nation in the region as a second nation.
So imagine where colonial America is a country, and all Americans also have England as a Second Nation. There is a European Tournament of Nations in which the US appears because all the US players are eligible (being also English citizens), but the game decides there is enough US talent that the US should be the entry. That appears to be what is happening.

I'm guessing no one anticipated this edge case, but there should be code to check that both the players AND the nations being allowed into the tournament are eligible.

FleetWalker · 09-16-2023, 01:48 PM

To add one troubleshooting wrinkle. Each of the first two times the tournament was held there was a SINGLE out-of-region nation. 7 of the 8 teams were in region, but 1 was not. The Out of Region nation choosen wasn't a particularly good candidate either. The first year it picked a country that had only two active eligible players when there were literally hundreds of Out of Region countries that could have fielded full teams of In Region players.

This makes me wonder slightly if there is there is a loop that is miscounting or stopping early and then a cleanup routine that is adding entities at random.

FleetWalker · 09-16-2023, 05:32 PM

So I've had two more tournaments happen, and both times a single nation from out of the region appeared. Those teams used ghost players despite the fact that every in-the-region nation should have more the enough players to field a team. And also, the league settings require only nations with active players are eligible to participate.

I think it's pretty clear that something is wrong with the way the teams are being picked for the tournament.

Matt Arnold · 09-17-2023, 11:30 PM

Does your tournament rotate the host city? It's possible that interaction is not working properly with the region filter, as I believe whatever host city is selected for the tournament is automatically included.

FleetWalker · 09-18-2023, 09:18 PM

Quote:

Originally Posted by Matt Arnold

Does your tournament rotate the host city? It's possible that interaction is not working properly with the region filter, as I believe whatever host city is selected for the tournament is automatically included.

Now that is interesting! It certainly explains the problem. The tournament was set to rotate cities . . . but there weren't actually any cities in the countries in the region.

I wanted to have a tournament where the teams were regional teams, but (1) the computer picked the teams based on talent, and (2) the teams retained history. So I created a fake continent (World Baseball Classic) and fake countries (US-Northeast, Europe, Africa, etc...) and then set it so each real country had as a second nation the relevant region at 100%. So everyone from (say) Spain had a second nation of Europe. I turned the states of Mexico and the US and the prefectures of Japan into "nations" so they could be placed in regions.

Since it was kind of pain to create the fake countries, for testing purposes I didn't bother giving them cities. I've remedied that, so I will test some more and see if the problem continues.

Thanks.

09-16-2023, 01:28 PM	#1
FleetWalker Minors (Double A) Join Date: May 2002 Location: Granby, CT Posts: 128	Regional Tournament of Nations Includes Out of Region Nations I think this is a bug. I created a tournament for nations that has a specified region. I'm assuming what happens if that game first looks to see what players are from eligible nations in the region then chooses nations based on available talent. That's fine, except that it is picking from nations NOT in the region. How can this happen? In my world, all the players from one nation that is out of the region also have a nation in the region as a second nation. So imagine where colonial America is a country, and all Americans also have England as a Second Nation. There is a European Tournament of Nations in which the US appears because all the US players are eligible (being also English citizens), but the game decides there is enough US talent that the US should be the entry. That appears to be what is happening. I'm guessing no one anticipated this edge case, but there should be code to check that both the players AND the nations being allowed into the tournament are eligible. Last edited by FleetWalker; 09-16-2023 at 03:14 PM.

09-16-2023, 01:48 PM	#2
FleetWalker Minors (Double A) Join Date: May 2002 Location: Granby, CT Posts: 128	To add one troubleshooting wrinkle. Each of the first two times the tournament was held there was a SINGLE out-of-region nation. 7 of the 8 teams were in region, but 1 was not. The Out of Region nation choosen wasn't a particularly good candidate either. The first year it picked a country that had only two active eligible players when there were literally hundreds of Out of Region countries that could have fielded full teams of In Region players. This makes me wonder slightly if there is there is a loop that is miscounting or stopping early and then a cleanup routine that is adding entities at random. Last edited by FleetWalker; 09-16-2023 at 01:49 PM.

09-16-2023, 05:32 PM	#3
FleetWalker Minors (Double A) Join Date: May 2002 Location: Granby, CT Posts: 128	Update So I've had two more tournaments happen, and both times a single nation from out of the region appeared. Those teams used ghost players despite the fact that every in-the-region nation should have more the enough players to field a team. And also, the league settings require only nations with active players are eligible to participate. I think it's pretty clear that something is wrong with the way the teams are being picked for the tournament.

09-17-2023, 11:30 PM	#4
Matt Arnold OOTP Developer Join Date: Jun 2009 Location: Here and there Posts: 15,787	Does your tournament rotate the host city? It's possible that interaction is not working properly with the region filter, as I believe whatever host city is selected for the tournament is automatically included.