Is the nameset random name generation bug fixed for 21?

Pendragon · 03-09-2020, 05:54 PM

There is a bug that keeps some names that are duplicated in multiple namesets from correctly generating random names for a given nation.

For example, if I try to generate a custom roster for a Scottish team, I'll get just a handful of first and last names from the nameset, resulting in many, many duplicate player names. Most of the first and last names in the Scotland nameset that are included in other namesets (e.g., England, Ireland) are not picked up by the name generator.

I've seen this posted for Australia/New Zealand as well.

Just curious whether this bug was addressed in OOTP 21 or if we are still going to have to manually rename players to get around this bug.

Rain King · 03-09-2020, 06:31 PM

Has this issue been posted in the bug forum?

Pendragon · 03-09-2020, 09:00 PM

Apparently it has in the past. I found this thread while I was searching to see if the problem had come up before:

https://forums.ootpdevelopments.com/...d.php?t=291860

joefromchicago · 03-10-2020, 09:55 AM

Quote:

Originally Posted by Pendragon

There is a bug that keeps some names that are duplicated in multiple namesets from correctly generating random names for a given nation.

Have you run into this problem recently? I seem to recall that this bug was supposed to be fixed in version 20, but I'm not sure of that. If it's still happening, then the development team should definitely fix it.

Pendragon · 03-10-2020, 10:24 AM

Quote:

Originally Posted by joefromchicago

Have you run into this problem recently? I seem to recall that this bug was supposed to be fixed in version 20, but I'm not sure of that. If it's still happening, then the development team should definitely fix it.

Yes. If I create a set of Scottish free agents, most are named Callum MacDonald or Callum Mackay, Ewan MacDonald, Ewan Mackay, etc.

This also happens for names generated for the Amateur draft.

Boomcoach · 03-10-2020, 10:47 AM

I would hate to see what it would do with Wales!

I know Wales has fielded a full rugby line-up named Jones, but a full roster!

joefromchicago · 03-10-2020, 10:47 AM

I'm disappointed to hear that. Gamers who want to play fictional set-ups will likely be disappointed as well. A lot of work has gone into namesets, it would be a shame if they can't be used as they were intended to be. Thanks for bringing this up, Pendragon.

Pendragon · 03-10-2020, 10:12 PM

Quote:

Originally Posted by Boomcoach

I would hate to see what it would do with Wales!

I know Wales has fielded a full rugby line-up named Jones, but a full roster!

This is what my team from Wales looks like in OOTP 20:

https://drive.google.com/open?id=1Nf...LjN9za5dP4faL7

Matt Arnold · 03-10-2020, 11:01 PM

Sorry, seems like this bug somehow missed making its way up to us to see or fix. So good news, I believe this will be fixed in OOTP21

In the meantime, I believe if you use the reimport name+ethnicity DB, that should actually reset things and behave properly. I don't believe that was affected by the same thing that caused problems in the other cases.

Pendragon · 03-10-2020, 11:10 PM

Thanks, Matt.

For those interested, I reimported the name+ethnicity DB and it seems to have fixed the issue. I got a more varied set of Scottish player names generated (including a player named Jack Jack).

Boomcoach · 03-11-2020, 06:57 AM

Quote:

Originally Posted by Pendragon

This is what my team from Wales looks like in OOTP 20:

https://drive.google.com/open?id=1Nf...LjN9za5dP4faL7

Nice!

BigRed75 · 03-11-2020, 07:14 AM

Quote:

Originally Posted by Pendragon

Thanks, Matt.

For those interested, I reimported the name+ethnicity DB and it seems to have fixed the issue. I got a more varied set of Scottish player names generated (including a player named Jack Jack).

You should re-name him Jock Jack...

joefromchicago · 03-11-2020, 08:31 AM

Quote:

Originally Posted by Boomcoach

I would hate to see what it would do with Wales!

I know Wales has fielded a full rugby line-up named Jones, but a full roster!

I encourage anyone who has the time and inclination to develop a Welsh nameset - we don't have one yet! Of course, there's the danger that half the last names will be Jones and the other half will be Lloyd, and all of the first names will be David, but that's just the Welsh for you

Pendragon · 03-11-2020, 11:07 AM

Unfortunately, I spoke too soon.

Reimporting the DB for an existing league fixed the problems for creating new free agents for that game, but not for new games.

I just tested creating a new fictional league, and the generated players only used a handful of names from the Scotland nameset--including 24 players named Callum Mackay.

Note: I am using the Scotland nameset as an example; this occurs for a number of namesets where the same names are included in multiple namesets.

Matt Arnold · 03-11-2020, 11:20 AM

Yeah, basically the problem is creating new games, re-importing the nameset will only fix the current game. So if you want it properly for a new game, you have to create the game, disable creating players (or delete all game-generated players), re-import the name DB, then regenerate all the players.

Pendragon · 03-11-2020, 11:37 AM

Ah, okay. Thanks again, Matt.

BigRed75 · 03-12-2020, 09:28 AM

Quote:

Originally Posted by Pendragon

24 players named Callum Mackay.

But really, isn't that pretty accurate for Scotland?

03-09-2020, 05:54 PM	#1
Pendragon Minors (Double A) Join Date: May 2019 Posts: 170	Is the nameset random name generation bug fixed for 21? There is a bug that keeps some names that are duplicated in multiple namesets from correctly generating random names for a given nation. For example, if I try to generate a custom roster for a Scottish team, I'll get just a handful of first and last names from the nameset, resulting in many, many duplicate player names. Most of the first and last names in the Scotland nameset that are included in other namesets (e.g., England, Ireland) are not picked up by the name generator. I've seen this posted for Australia/New Zealand as well. Just curious whether this bug was addressed in OOTP 21 or if we are still going to have to manually rename players to get around this bug.

03-10-2020, 10:47 AM	#6
Boomcoach All Star Reserve Join Date: Nov 2017 Posts: 846	I would hate to see what it would do with Wales! I know Wales has fielded a full rugby line-up named Jones, but a full roster! __________________

03-10-2020, 10:47 AM	#7
joefromchicago Hall Of Famer Join Date: Jun 2011 Posts: 3,725	I'm disappointed to hear that. Gamers who want to play fictional set-ups will likely be disappointed as well. A lot of work has gone into namesets, it would be a shame if they can't be used as they were intended to be. Thanks for bringing this up, Pendragon. __________________ American-Ethnic (and Canadian) Namesets Historical Minor League Schedules 1870s City/Team Nickname Randomizers "It's Usually Sunny in Philadelphia" weather mod Negro League Schedules

03-10-2020, 11:10 PM	#10
Pendragon Minors (Double A) Join Date: May 2019 Posts: 170	Thanks, Matt. For those interested, I reimported the name+ethnicity DB and it seems to have fixed the issue. I got a more varied set of Scottish player names generated (including a player named Jack Jack). Last edited by Pendragon; 03-10-2020 at 11:42 PM.

03-09-2020, 06:31 PM	#2
Rain King Hall Of Famer Join Date: Nov 2005 Posts: 3,323	Has this issue been posted in the bug forum?

03-09-2020, 09:00 PM	#3
Pendragon Minors (Double A) Join Date: May 2019 Posts: 170	Apparently it has in the past. I found this thread while I was searching to see if the problem had come up before: https://forums.ootpdevelopments.com/...d.php?t=291860

03-10-2020, 11:01 PM	#9
Matt Arnold OOTP Developer Join Date: Jun 2009 Location: Here and there Posts: 16,218	Sorry, seems like this bug somehow missed making its way up to us to see or fix. So good news, I believe this will be fixed in OOTP21 In the meantime, I believe if you use the reimport name+ethnicity DB, that should actually reset things and behave properly. I don't believe that was affected by the same thing that caused problems in the other cases.

03-11-2020, 11:07 AM	#14
Pendragon Minors (Double A) Join Date: May 2019 Posts: 170	Unfortunately, I spoke too soon. Reimporting the DB for an existing league fixed the problems for creating new free agents for that game, but not for new games. I just tested creating a new fictional league, and the generated players only used a handful of names from the Scotland nameset--including 24 players named Callum Mackay. Note: I am using the Scotland nameset as an example; this occurs for a number of namesets where the same names are included in multiple namesets.

03-11-2020, 11:20 AM	#15
Matt Arnold OOTP Developer Join Date: Jun 2009 Location: Here and there Posts: 16,218	Yeah, basically the problem is creating new games, re-importing the nameset will only fix the current game. So if you want it properly for a new game, you have to create the game, disable creating players (or delete all game-generated players), re-import the name DB, then regenerate all the players.

03-11-2020, 11:37 AM	#16
Pendragon Minors (Double A) Join Date: May 2019 Posts: 170	Ah, okay. Thanks again, Matt.