News message typos

[injury log]

A couple more news message typos in the english.xml file:

in id 19041: "Here's his his updated report" --> "Here's his updated report"

in id 16266: "to pace [%team#1nickname]" will in almost all circumstances work better as "to pace the [%team#1nickname]"

EDIT (addition): in id 15557, there are four separate quotation marks that all print incorrectly (this might be one that was caught previously), e.g. on "...“His breaking pitches..."

EDIT (another addition): this is one that has bothered me for a while. In id 649, the pitcher of the month says about the fans: "They might boo you when you're getting knocked around, but they love you when you're firing BBs." I always read this as "they love you when you're firing walks"- it's a baseball sim after all! So maybe 'BBs' should be replaced with 'bullets' or similar.


Also a couple of questions about the injury-related news items:

-First, I assume none of them are hardcoded, and that all can be edited in the xml file?

-Second, not really a question but more invitation for comment: Injury news items sometimes call on the diagnosis field in the injury database [%injury] and sometimes the descriptive field [%injurydescription]. When the game calls on the diagnosis field, some news items are certain to read awkwardly for some injuries, because of the way indefinite articles are used. If a news item says 'Player X will miss time with a [%injury]', this is fine with 'fractured tibia', but with 'back spasms' it reads 'Player X will miss time with a back spasms', and with 'arthritic knee' it's 'with a arthritic knee'. The use of indefinite articles is also inconsistent (some say 'with a [%injury]', some 'with [%injury]'), so one can't fix the problem by rephrasing all diagnoses to accept an 'a' before them. If the game always used [%injurydescription] and left out the indefinite article, it seems it would be easier to make the news items read cleanly. I'm going to try an edit of the xml file to see if I can get this to work, in any case. It's obviously a very low-priority issue. Largely because the news items are very well done overall, these minor mistakes jump off the page when I see them.

[battists]

Hi there.

The specific IDs you mentioned have all been fixed.

Regarding the injury messages, they should also (I believe) all be in the XML. I agree, using injury description consistently would be best.

Er, if you're bored, care to let me know which IDs don't use it? I'll try to get someone to take care of this!



Steve

[injury log]

Sure thing- actually, I can list all of the changes needed to make all injury items read properly:

First, just in case it's helpful to someone trying to make sense of my suggestions below, in the standard injuries.txt file, the diagnosis [%injury] and the description [%injurydescription] only differ, potentially, in two ways: %injurydescription includes an indefinite article if needed, while %injury sometimes specifies a body part in brackets. e.g.:

%injury - torn labrum (shoulder)
%injurydescription- a torn labrum

%injury - back spasms
%injurydescription - back spasms

I don't need to see '(shoulder)' in news items, and it seems the purpose of the %injurydescription field is to get the indefinite article right in news articles, so I'm now absolutely sure it's meant to be used almost throughout the xml file.

The following items use the diagnosis field, and can all produce the 'a back spasms' problem. Just doing a find-replace, replacing 'a [%injury]' with '[%injurydescription]' will fix them. NB the indefinite article ('a') needs to be removed from english.xml, or else there will be a lot of 'a a fractured femur' news stories. I've included the lead-in wording from english.xml:

using %injury [diagnosis field]
17580 'result of a ...'
18480: 'was diagnosed as a ...'
18481: 'day-to-day with a...'
18482: 'suffered a...'
18483: 'sustained a...'
18484: 'due to a ...'
18486: 'suffered a ...'
18488: 'attempts to shrug off a ...'
18489: 'with a ...'
18490: 'suffered a ...'
18494: 'has a ...'
18495: 'suffered a ...'
18496: 'sustained a ...'
17582: 'has a ...'
18458: 'diagnosis is a ...'
18462: 'diagnosed as a ...'
18467: 'developed a ...'
18468: 'revealed the injury to be a ...'
18469: 'suffered a ...'
18470: 'suffered a ...'
18471: 'suffered a ...'
18473: 'sustained a ...'
18474: 'suffered a ...'
18475: 'suffered a ...'
18476: 'with a ...'
18478: 'with a ...'
18479: 'with a ...'
19033: 'has a ...' [off-field]
19034: 'with a ...' [off-field]
19035: 'with a ...' [off-field]
19036: 'suffered a ...' [off-field]
19037: 'with a ...' [off-field]
19038: 'with a ...' [off-field]
19039: 'suffered a ...' [off-field]
19040: 'suffered a ...' [off-field]

-------

The following do not use an indefinite article, but still use the diagnosis field. They can produce lines like 'after suffering broken tibia'. Here '[%injury]' should simply be replaced with '[%injurydescription]':

17756 'diagnosis of ...'
17755 'diagnosis was ...'
17747 'reporting the injury as ...'
17748 'after suffering ...'
17750: 'was diagnosed as ...'
17759: 'diagnosis was ...' [illness]
18472:' due to ...'

There is one xml entry that uses the diagnosis field, and which will read incorrectly if changed- must be left as is:

18477: 'play through his ...'

And I think this one should be fine either way, since it's a headline:

18329: "Star DTD with [%injury capital]"


The following use %injurydescription, and should be fine as is:

17757: 'suffered ...'
17746 'suffered ...'
17749: 'result of ...'
17667: 'diagnosed with ...' [illness]
17668: 'diagnosed with ...' [illness]
17758: 'suffering from ...' [illness]
17730: 'with ...'
17732: 'after suffering ...'
17733: 'with ...'
17734: 'with ...'
17583: 'has ...' [off-field]
17769: 'after suffering ...' [off-field]

That's the complete list, I believe. Sometimes the off-field news items combine text from the off-field file with the injury diagnosis or description, and I haven't really thought about whether that could produce problems if changed- I doubt it, though. There's one typo as well in the injuries.txt file: 'a inguinal hernia' should be 'an inguinal hernia'.

[injury log]

One final note: I've made these changes to the xml file (didn't take long, but I'd be happy to email it to you if it would be helpful). There are still occasional issues with verbs, now:

id 17749: "Tony Pena of the Baltimore Orioles is probably going to miss a day or two as a result of back spasms that doesn't seem to be getting better quickly."

At least it doesn't say 'a back spasms', but it would read better in all cases as follows:

"Tony Pena of the Baltimore Orioles is probably going to miss a day or two as a result of an injury - [%injurydescription] - that doesn't seem to be getting better quickly."

[Eugene Church]

Originally Posted by injury log

A couple more news message typos in the english.xml file:

in id 19041: "Here's his his updated report" --> "Here's his updated report"

in id 16266: "to pace [%team#1nickname]" will in almost all circumstances work better as "to pace the [%team#1nickname]"

EDIT (addition): in id 15557, there are four separate quotation marks that all print incorrectly (this might be one that was caught previously), e.g. on "...“His breaking pitches..."

EDIT (another addition): this is one that has bothered me for a while. In id 649, the pitcher of the month says about the fans: "They might boo you when you're getting knocked around, but they love you when you're firing BBs." I always read this as "they love you when you're firing walks"- it's a baseball sim after all! So maybe 'BBs' should be replaced with 'bullets' or similar.


Also a couple of questions about the injury-related news items:

-First, I assume none of them are hardcoded, and that all can be edited in the xml file?

-Second, not really a question but more invitation for comment: Injury news items sometimes call on the diagnosis field in the injury database [%injury] and sometimes the descriptive field [%injurydescription]. When the game calls on the diagnosis field, some news items are certain to read awkwardly for some injuries, because of the way indefinite articles are used. If a news item says 'Player X will miss time with a [%injury]', this is fine with 'fractured tibia', but with 'back spasms' it reads 'Player X will miss time with a back spasms', and with 'arthritic knee' it's 'with a arthritic knee'. The use of indefinite articles is also inconsistent (some say 'with a [%injury]', some 'with [%injury]'), so one can't fix the problem by rephrasing all diagnoses to accept an 'a' before them. If the game always used [%injurydescription] and left out the indefinite article, it seems it would be easier to make the news items read cleanly. I'm going to try an edit of the xml file to see if I can get this to work, in any case. It's obviously a very low-priority issue. Largely because the news items are very well done overall, these minor mistakes jump off the page when I see them.

Sorry for the delay in the response. I just saw this thread yesterday...but better late than never.

Thanks for telling us about the errors. Your help is much appreciated.

I wish there were more people like you.

I checked the Text Database and all the typos have been fixed and [%injury] has been replaced by [%injurydescription].

I didn't change "BBs". I can see your confusion, but from context, it is about small pellets and not bases on balls.

BBs can be "bases on balls" and sometimes "BBs" as in "the ball looks so small that it seems to the batter that he is trying to hit BBs" as in "small pellet".

I think from context the reference is to "throwing so well that the ball looks as small as a BB...small pellet" and not to issuing bases on balls. The fans would not love you if you are walking a lot of batters. They would be happy if you are hard to hit and are throwing so well the ball is looking like a small pellet or BB to the hitters".