The XML File Suggestion Thread

[battists]

Just cross-posting for the heckuvit:

http://www.ootpdevelopments.com/boar...d.php?t=122972

[canadiancreed]

Originally Posted by RBLwebguy

dola,

but you have done a great service

no kidding. I'd like to get hands on just waht ones needed to be changed.

[battists]

Just FYI, [%game pitch description] is one of the weird exceptions in the PbP. It's a token that is used in options to describe a good pitch only, but instead of providing a hard-coded value, it provides a random value from one of the PITCH_DESCRIPTION categories such as PITCH_DESCRIPTION_CURVEBALL (category ID 317), based on whatever the pitch actually was.

[tysok]

I just took a break for a bit and tried some steals, since I'm going through those now... actually I'll post this now, just cuz:

Category 304, 305, 306, and 307 are the stolen base to 2nd and 3rd plays. In here the catcher is throwing, the slide, etc etc...
I went through some categories previous that had the catcher throwing to 2nd and 3rd... thought those were the throw lines for the stolen bases. What are those lines?

Because in my game (with 12 stolen bases and 15 caught stealin - including 4 of home, 6-5 loss) I just noticed the stolen base lines, and not the throw lines. Obviously I was wrong at first.

Anyhow, I often saw something like
Paco takes off
Johnson takes low and in
blah blah
Paco broke but decided to stop.

Is this a mistake? Or is this intentional faking out?

[battists]

Originally Posted by tysok

I just took a break for a bit and tried some steals, since I'm going through those now... actually I'll post this now, just cuz:

Category 304, 305, 306, and 307 are the stolen base to 2nd and 3rd plays. In here the catcher is throwing, the slide, etc etc...
I went through some categories previous that had the catcher throwing to 2nd and 3rd... thought those were the throw lines for the stolen bases. What are those lines?

Because in my game (with 12 stolen bases and 15 caught stealin - including 4 of home, 6-5 loss) I just noticed the stolen base lines, and not the throw lines. Obviously I was wrong at first.

Anyhow, I often saw something like
Paco takes off
Johnson takes low and in
blah blah
Paco broke but decided to stop.

Is this a mistake? Or is this intentional faking out?

tysok, check out the excel sheet that I posted. That should help...

[tysok]

So close, yet 21 pages to go.

10388
"[%game catcher] snap off a bullet "
Should be "snaps off"

7653
"[%game base3] is a meat at the plate"
Drop "a"

7656
7660
"[%game thirdbase] is thrown out at the plate!"
Who's on third? No he's on first... but who's running home?
Should be [base 3]

10435
"score that a heads up play on part of the runner."
Should be "on the part of the runner"

10404
14502
10730
10731
10779
10780
10781
10491
10668
10449
10638
"OUT!(nl)[%game outs+1 long]"
Need a reference to what [outs] is.

10415
"[%game catcher] fires a strike to second...(nl)the slide...(nl)got [%game base2] with an accurate throw."
This should "got [base1] with"

10421
10422
"[%game base1] goes in hard and upends (%game fielder]..."
The other lines in this category are calling [fielder2]. Also Need [ instead ( for [fielder]

6725
"[%game catcher] is doesn't risk a throw"
Should drop "is"

6730
"[%game catcher] bobbles the transfer to his throwing arm(nl)he won't get off a throw(nl)[%game secondbase] is into third easily"
Another fielder stealing bases. This should be [base2]

14488
"[%game pitcher] rung him up a [%game pitch description]"
Should be "rung him up on a [descr]"

10817
10822
10742
10745
10792
10795
"sends [%game batter] back to the dugout with the bat still on his shoulders..."
If the bat was on both shoulders he was physically unable to swing it. Should be "on his shoulder"

10829
"got him on a [%game pitch description] inner half"
Should be "[descr] on the inner half"

10701
"strike three inside corner..."
The rest of this category is talking about strike three on the outside corner.

10704
10754
"got him on with a [%game pitch description]!"
Should drop "with" or "on"

10741
10791
"[%game batter] thought it was a way outside..."
Should drop " a way" or "a" or combine "a way" to away and drop "outside"

10922
"swing on...(nl)and missed!"
Should be "swung on"

10490
"[%game catcher] scrambles, but cant come up with it..."
Contraction, "can't"

10693
10656
"swing and a miss!(nl)swing and a miss!(nl)a big cut by [%game batter].."
Swing and miss twice... or was it that big of a cut?

14759
TEXT_OBJECT id="14759" text="swung on...(nl)and missed...(nl)boy, oh boy, he couldn\'t hit that pitch with a bed slat...(nl)it was waaaaay outside" only_once_per_x2="1"/>
Might this one come up for an inside pitch? At least most of these in this categroy call [pitch location]

10442
"but he gets to it quickly and retires [%game batter] easily at first..."
This category appears to be for catchers grabbing the ball and tagging the batter.

10451
"picks it up and applies the tag...(nl)he did well to keep the ball in front of himself"
Should be "keep the ball in front of him"

[tysok]

This is it! I've just read line number 43,136... the last line on page 763... the 320,145th word... the 2,447,120th character... and it all ends with:

"TEXT_FILE"

Not very dramatic.
The file with the patch is smaller by 7 pages.

6698
"[%game fielder2] snags on a hop"
Should be "snags it on"

8263
"too high for [%game fielder] to get..."
Should be [fielder2]

8301
"[%game fielder2] just watches it goes over his head..."
Should be "watches it go over"

TEXT_CATEGORY id="139">
TEXT_OBJECT id="4059" text="test"/>
TEXT_OBJECT id="4062" text="rtghdghdfgdfg"/>
TEXT_CATEGORY>
TEXT_CATEGORY id="138">
TEXT_OBJECT id="4060" text="test"/>
TEXT_OBJECT id="4061" text="dsfgsfgafgasfg"/>
TEXT_CATEGORY>
In case the announcer just can't come up with words to describe the play...

23
"[%teamlink] has a new manager"
This section is talking about General Manager.

413
"Although the club had been looking to go a new direction for some time"
Should be "looking to go in a new"

422
"[%personlink] and several of his [%teamlink nick] players visited with some school children "
This just reads weird to me. Looks to say "several of his Cardinals players". I'd change it to "several [teamlink nick] players"

424
"We have several questionmarks to resolve"
2 words, question marks

426
"New managers are always in a rough spot"
This section is talking about General Managers

136
137
"[%teamnickname] Head in New Direction with Hiring of [%personname F L] as Their New Manager"
These are headlines for hiring new General managers

983
"[%teamname] Sign [%personname F L] "
This should be "[team] signs [person]"

996
"[%teamnickname] Hires [%personname F L] "
This should be "[teamnick] hire [person]"

10974
"wild pitch...(nl)through the wickets...(nl)[%game catcher] couldn't get his glove on it"
Usually if it goes through the catchers legs (through the wickets) it's a passed ball instead of a wild pitch.

That's it. No doubt there's other errors in there, but no variable and name errors at least. If there's anything else I can help yall with let me know.

[battists]

You've done a great service, tysok! Wish you'd been on the team from the start.

(Did you get a chance to download the spreadsheet, and was it helpful??)

[tysok]

I was just looking back through everything and saw a section I'd posted that had bunches of errors in career batting area. The response was that stuff was going to be overhauled soon, so I figured none of it had been "fixed". There was 1 play at the top of the list that was actually a play by play.

Don't know if you just missed that one, or you chose to leave it alone.
It could have just been lumped in with the majority in that post, so I'll tag it up here again just to make sure.

11461
"rounds first...(nl)he'll bluff a throw(nl)and retreat to the bag"
He'll bluff a throw? I saw some where it says he tries to draw a throw... don't think anyone's gonna fall for the runner bluffing a throw, and where will he throw?

I got it downloaded, but forgot to look at it before I started up this morning.

[Raidergoo]

Of course you know this means war.


I think RBLwebguy will play catch up and implement changes as needed like he has been.

Of course, once revised, it will need revised again.

And again.

And again.

[tysok]

Take your dancin banana and go home!

I'd like to set the variables and see the finished text, without having to go through the game... but don't seem to be able to do so. That would probably catch more of the hidden errors... I'm pretty sure all the occasions where it references the wrong player, hard numbers/names instead of variables, or where it doesn't tell you what the [] number means is taken care of.

Punctuation (quote marks, apostrophes, etc) and new line problems (if it starts a new line in the middle of a phrase for no reason) is extremely hard for me to pick out with all the coding around it. Also occasions where what [the reference] will call up and the wording around it was guesswork sometimes.

Just make sure RBL doesn't go around inserting errors and you can be fairly confident.

Oh... and I do see your banana... and raise you:

[RBLwebguy]

Guess I got some work to do this weekend

I took a few days off since the patch was released to get some work done around here

[battists]

tysok, in case you don't normally, please check your PMs.

[halos17]

tysok,

I sent you a PM. Get back to me this evening if you can.

[Eugene Church]

Originally Posted by tysok

I have 2 announcements that the postseason is starting. Both on 10/3:

First: The Major League playoffs start today! Only a handful of teams remain to battle for the ultimate prize. Today is the start of the Division Series, and most of the teams will be trying to put their best foot forward in these matchups: (but nothing listed)

In the first item...third sentence...there should be no comma between "Series" and "and"...this is a simple compound sentence...no comma is needed.

[Eugene Church]

Originally Posted by AliG

Pretty obvious but is that kinda language allowed here? Not sure if it has some other meaning but I don't really want to know what he did to that trophy no matter how happy he was that he won it.

"shag" in baseball means to "catch"...as in "to shag fly balls".

In this story it means to "to get the trophy" or "to grab the trophy".

I didn't write it...but it is an acceptable word that is used in baseball.

[tysok]

Here's a couple newly located.

[187-8604] the 0-1 pitch...
Helu from the stretch, delivers...
[189-11381] the batter offers at it...
[225-13559] crushed...
[234-12129] into right-center field...
[239-14269] Ring charges for it...
[257-11497] and the ball clears the fence on one hop...
that's a ground-rule double...

This was reported somewhere else. But it's in the game instead of pbp, it calls category 225 (flyball hard) then category 239 (flyball charge).
This is an interesting problem. How does the game handle conditions? It randomizes the text I know... In category 243 it has conditions on a few. Does it look at the text to see if a condition works, and if so uses that one... or will it use them in order until it's time for that one and then if it doesn't meet the conditions it skips it...
Anyhow, there needs to be a condition statement for racing back in that 239 category I guess.

***

TEXT_OBJECT id="7730" text="a run scored by [%personname l]"/>
This line doesn't fit. I hunted down 3 or 4 and they're all the same, it's scoring on a hit. These are a couple calls:
(1)
[258-11526] it's going back...
Mugo will watch it carom off the wall...
[222-11481] Phillips is thinking double...
he races toward second...
-----------
[15-7729] Beckmann scores for Boston...
-----------
[14-7707] Yamagata takes third...
-----------
[15-7730] a run scored by Yamagata...

(2)
[301-10383] Corelli pumps, fires to third...
[296-13758] but it's wild!
That'll be an error on Corrigan...
-----------
[15-7730] a run scored by Cavuoto...
-----------
[14-7699] Were moves over to third...

The rest in this category are like "Someone scores a run" ... the format for this one just doesn't fit in with how it's called.

***

TEXT_OBJECT id="7718" text="[%personname l] comes into score..."/>
Should be "comes in to score"

[tysok]

Forgot to mention this one.
Not a problem with the text, as far as I know at least...
These 2 objects:
TEXT_OBJECT id="9725" text="ball [%game balls+1 long]...(nl)[%game pitcher] misses with a [%game pitch]..."/>
TEXT_OBJECT id="9750" text="[%game pitcher]\'s pitch is [%game pitch location] to [%game batter]...(nl)ball [%game balls+1 long]..."/>

Don't appear to ever be called. I've gone through searching for category number on the game logs, every other line in this category (191) was called then restarted without ever calling these two lines.

[M's rule]

For those who are interested in this saga, I'll throw out a brief update.

Between RBLwebguy and me, I think we've dealt with the majority of the issues that tysok identified. For my part, I've worked through the material in posts 60, 73, and 76 of this thread, and the database is now a lot better off for it. Thank you, tysok, for your sharp eye and your lack of a life.

I will continue to make my way through the other posts in this thread and incorporate as much information from them as I can.

Aside from the job I call Project Tysok, a few folks have been hard at work continuing to polish and streamline the database. As you can see for yourself, it's a huge and complex mass of information. We are a ways from our goal (which is, of course, perfection), but we are making good progress.

Just didn't want anyone to think that this work had slowed down, or that changes in the database are limited only to what we've fixed in reaction to this and other threads.

k

[Raidergoo]

Originally Posted by M's rule

Aside from the job I call Project Tysok

k

The Alan Tysok Project?