Integer underflow in draft player's generated stats

Jamee999 · 10-30-2018, 11:42 PM

Slightly odd one here.

The league I'm running has 19th century stats, but is otherwise relatively normal. The photo attached shows George Thompson, who was the number one prospect in the 1873 draft. However, as you can see in the first line of his stats, his college statistics are terrible. 46.66 ERA. Feeders are off, so these are just the auto-generated stats by the game.

As he is shown as having 255 homers conceded, I suspect that somehow the calculation for home runs tried to return a value of -1, but couldn't do it, and so wrapped around to be 255 instead. This is possibly related to the low HR environment of the league, Thompson's good movement rating, and the fact that he is an extreme groundball pitcher.

Obviously this isn't a huge deal, but it could cause problems for a user who was playing in stats-only mode, if they saw a generational-talent pitcher with a terrible college ERA.

Thanks guys, loving OOTP 19.

Matt Arnold · 10-31-2018, 08:57 AM

Thanks, yeah, definitely feels like we were trying to give him -1 HR there

10-30-2018, 11:42 PM	#1
Jamee999 All Star Reserve Join Date: Jan 2005 Posts: 769	Integer underflow in draft player's generated stats Slightly odd one here. The league I'm running has 19th century stats, but is otherwise relatively normal. The photo attached shows George Thompson, who was the number one prospect in the 1873 draft. However, as you can see in the first line of his stats, his college statistics are terrible. 46.66 ERA. Feeders are off, so these are just the auto-generated stats by the game. As he is shown as having 255 homers conceded, I suspect that somehow the calculation for home runs tried to return a value of -1, but couldn't do it, and so wrapped around to be 255 instead. This is possibly related to the low HR environment of the league, Thompson's good movement rating, and the fact that he is an extreme groundball pitcher. Obviously this isn't a huge deal, but it could cause problems for a user who was playing in stats-only mode, if they saw a generational-talent pitcher with a terrible college ERA. Thanks guys, loving OOTP 19. Attached Images

10-31-2018, 08:57 AM	#2
Matt Arnold OOTP Developer Join Date: Jun 2009 Location: Here and there Posts: 14,136	Thanks, yeah, definitely feels like we were trying to give him -1 HR there