|
||||
|
06-02-2006, 01:41 PM | #21 | |
Hall Of Famer
|
Quote:
|
|
06-02-2006, 02:49 PM | #22 | |
Hall Of Famer
Join Date: Aug 2003
Posts: 4,925
|
Quote:
[%leaguename] and looked at them all. A lot of them were fine. Examples of good ones: Playing in his first Major League game. Major League GMs... I'm a Major League ballplayer... A lot weren't. Examples of not good (since nothing is bad) ones: Major League announces... Scouting report on Major League... Playoffs begin today for Major League... There's two ways to fix a lot of these, add 'the' in front, so it's The Major League announces, Scouting report for the Major League, Playoffs begin today for the Major League... or add baseball to the end, so it's Major League baseball announces, Scouting report for Major league baseball, Playoffs begin today for Major League baseball.... Some of them have to have 'the'. I tried anything I could think of in my mind where it would be fine (like John's league, Bear league, anything silly league) but they just don't work no matter what league name is there. But at least one is border line, and I may have gotten slap happy and added one that was fine... it shouldn't be hard to decide what should be done to fix it and I'll leave that up to you. Anyhow, here's the list... I just put the TEXT OBJECT ID number, any notes to the side is either 2 problems in one set, another error I noticed in that set, or a question whether wording makes sense or should be added. There's 192 occasions. Code:
2582 866 1591 4127 1943 926 1598 4758 1271 931 115 4759 105 109 1415 4761 660 1605 1417 2873 661 1606 1418 2900 664 1607 1422 3006 104 1610 1423 3007 671 1611 1427 3008 672 1612 1428 3009 673 1616 1429 3010 674 1618 1430 4768 675 1619 1432 4946 676 1621 888 5001 678 111 889 5004 680 1454 891 4871 103 1463 117 919 703 1469 848 1790 704 1475 853 1173 705 1028 1369 1676 706 1031 2215 1514 707 1034 1490 1736 708 1035 3953 1744 847 1036 3972 2166 106 1038 4461 714 867 History???? 1039 4463 716 868 1040 3217 343 869 1044 3264 745 873 2nd one 1053 2741 749 875 1055 2766 750 876 1056 2779 2nd one 751 877 1061 2786 752 108 1062 3860 753 830 113 3882 757 scoutING report? 834 1388 3145 761 835 1390 2 of them 3466 342 836 1391 3467 726 837 1403 3468 729 838 1405 3469 731 339 114 3471 738 879 839 3472 740 1007 842 3473 415 1010 843 4110 119 844 4113 854 845 4115 855 846 4116 856 1004 4118 859 1005 season after year? 4120 861 1589 4122 863 1590 4125 |
|
06-02-2006, 03:01 PM | #23 |
Hall Of Famer
|
Tysok,
The problem the text team ran into with this issue is the different ways of writing league names. For example, look at this sentence: Today, Major League Baseball announced... But if the league happens to be called "American Baseball League," then Today, the American Baseball League announced... kinda sounds better. I'm not saying you're wrong . . . I agree. It's just that there probably isn't a solution here that is going to resolve the issue for all parties, you know what I mean? Thoughts? |
06-02-2006, 03:33 PM | #24 |
Hall Of Famer
Join Date: Aug 2003
Posts: 4,925
|
You're quite right. If the name of the league includes "baseball" then adding baseball to the end doesn't work. But "the" still works.
In those occasions I mentioned, can't recall all 192 of course, all of them were fixable by "the" but some could be fixed by adding "baseball" at the end... but when the league name includes baseball (American Baseball League) it doesn't work. So wouldn't it seem then that every one needs "the"? You changed the text slightly in your example. 2 leagues, Major League American Baseball League Both could very well be what someone might call the league, I agree. I don't think anyone would actually call it Major League Baseball, as that's more of a differential between Major League what.... I could be wrong of course, lots of people labeling leagues. Then the text would say: Today, Major League announced... or Today, American Baseball League announced... The first could also be fixed by "baseball" at the end, but not the second. But both need "the". Even if the league name was generic like just John, or American League Baseball you would still be referring to a single entity comprised of several pieces. It's just labeled in such a way the "the" in front makes it seem weird, but is still technically right. God knows there's plenty of that type of thing in the English language. Also since half of them are "right" to me, it seems odd that they're not at least all uniform in being "wrong", but the size of the project could easily make that very difficult to achieve. What do you think of that? I admit I'm not overly creative in how leagues could be named, I have my style and can't think out of that style. Can you think of one where that wouldn't still be technically correct? It's definately not a killer, it's just annoying to me (and not overly so). By the way, I'm astounded by the number of items in there. Huge collection of ways to say the same thing... this couldn't have been easy. |
06-02-2006, 04:18 PM | #25 |
Hall Of Famer
Join Date: Aug 2003
Posts: 4,925
|
Sorry, I'm bored today and wasting time till I have to go to work.
I was looking through the xml file and reading all the lines, and found a repetitive mistake that I don't feel like mentioning every occurence unless necessary.... can you do a search through the file for "OPB" and fix them? Or do I need to list them? They should all say OBP... one such occurence is in text object id 2240. I've already found 9 of these. 2240: TEXT_OBJECT id="2240" text="[%personlink L] has batted [%batting avg] for his career, belted [%batting h word] in [%batting ab word], laced [%batting d word], [%batting t word] and unloaded [%batting hr] shots into the seats. He has also produced [%batting rbi] RBI and scored [%batting r] times. He has been in [%batting g word] and registered a [%batting slg] slugging percentage and a [%batting obp] OPB."/> Last edited by tysok; 06-02-2006 at 04:26 PM. |
06-02-2006, 04:34 PM | #26 |
All Star Starter
Join Date: Apr 2004
Location: Not Here
Posts: 1,226
|
I'll edit this later when I get a chance to recreate it and get a screen shot.
When I was hired for a Rookie level club, it referred to me as the GM even though I was only able to be the Manager. That particular announcement also indicated that I'd be able to show off my skills in the Inaugural Draft, but since I was only the manager of a minor league club, I'd be having nothing to do with the draft.
__________________
Beer Snob and Baseball Sim Geek |
06-02-2006, 04:46 PM | #27 | |
Hall Of Famer
|
Quote:
|
|
06-02-2006, 04:48 PM | #28 | |
Hall Of Famer
|
Quote:
No recreate/screenie needed on this one. |
|
06-02-2006, 05:23 PM | #29 | |
Hall Of Famer
Join Date: Aug 2003
Posts: 4,925
|
Quote:
I found a couple other problems, but no time to post them yet... nothing repetitive yet like OPB though. |
|
06-02-2006, 06:46 PM | #30 |
Minors (Single A)
Join Date: Apr 2002
Posts: 56
|
Pretty obvious but is that kinda language allowed here? Not sure if it has some other meaning but I don't really want to know what he did to that trophy no matter how happy he was that he won it. |
06-02-2006, 06:52 PM | #31 |
Hall Of Famer
Join Date: Jun 2002
Location: Canuckistan
Posts: 5,157
|
hehe, now that is probably not the best choice of word I will edit it now (wasn't mine btw)
|
06-03-2006, 12:03 AM | #32 | |
Hall Of Famer
|
Quote:
|
|
06-03-2006, 01:02 AM | #33 |
Hall Of Famer
Join Date: Aug 2003
Posts: 4,925
|
Here's a couple I found, been searching through the actual XML page:
Format: TEXT OBJECT ID # - clip that contains the problem - what it is 11461 "rounds first...(nl)he'll bluff a throw(nl)and retreat to the bag" He'll bluff a throw? I saw some where it says he tries to draw a throw... don't think anyone's gonna fall for the runner bluffing a throw, and where will he throw? 2268 2278 2279 2280 "He has chalked up [%batting h] all-time hits, 16 of which have gone for extra bases" 16 instead of a variable... some guys may have more or less EBH than others. 2272 2273 2275 2276 "His lifetime OBP is [%batting avg] with a [%batting slg] slugging percentage." Looks like it's pulling up the battings average stat instead of the OBP stat for the OBP reference. 2277 "[%batting hr word] and rung up a lifetime .333 OBP with a [%batting slg] slugging percentage. " .333 OBP instead of a variable. 2286 "He has also walked [%batting bb] time, stolen [%batting sb] bases and put up a [%batting obp] OBP" Should be walked [] times. 2335 "A review of his career stats reveals he has played in [%batting g word], gone to the plate [%batting ab] times" It's pulling up his number of AB but saying it's his PA. 2337 "stepped to the plate [%batting ab] times " Same as 2335. These may be okay I guess, just wording leads to one thing but then the call goes for something else. 2577 "And he did it [%batting g] games" Shouldn't it be "did it in [] games? It's been fun reading these lines, one could probably play through many seasons and never see some of them. I've just scratched the surface of them too... think I've knocked off 7 pages so far... |
06-03-2006, 01:55 AM | #34 |
Hall Of Famer
Join Date: Aug 2003
Posts: 4,925
|
I don't actually know that this is a problem.... but RBI is listed differently all over the place. I notice a lot of it in the [batteraward] area, it's listed a lot as just RBI, but most places (and at least one place in the [batteraward] areas it's listed as RBIs.
Since RBI stands for Runs Batted In it's already plural, but normally we say RBIs.... and seems it's referred mostly as RBIs through the XML page. Either way, there's a bunch of those if that's a problem. |
06-03-2006, 09:00 AM | #35 |
Minors (Single A)
Join Date: Apr 2002
Posts: 56
|
Here is one that AliG definitely wouldn't have complained about. Just doing my bit to perfect and already outstanding game.
As you can see, the news headline says Glove Wizard Award Award Winners announced. My league setup has the award named as the default 'Glove Wizard Award' so the news must be adding an extra Award to the end of it. |
06-03-2006, 09:42 AM | #36 | |
Hall Of Famer
Join Date: Jun 2002
Location: Canuckistan
Posts: 5,157
|
Quote:
I would imagine alot of the award headlines and stories are set up like that, as most people wouldn't add the word "Award" in renaming the awards If we remove that word from all stories, you would see: [awardname] winners announced. i.e. MVP winners announced..., gold glove winners announced...cy young winners announced... Maybe removing the name will work for everyone |
|
06-03-2006, 09:44 AM | #37 | |
Hall Of Famer
Join Date: Jun 2002
Location: Canuckistan
Posts: 5,157
|
Quote:
|
|
06-03-2006, 12:33 PM | #38 |
Hall Of Famer
Join Date: Aug 2003
Posts: 4,925
|
Another set of problems I noticed.
1875 "[%playerposition] hit .333 and knocked in 102 runs, while scoring 5. He hit for power as well, collecting 16 extra-base hits with 12 of them going out of the park!" Very consistent hitter, early in the season he'll have done really well but at some point he'll peak and never do better. Missing some variables. 5130 "These numbers, combined with a [%batting obp] earned him [%subleagueabbr] Batter of the Month honors" Don't know if that's wrong. Usually this kind of call has something telling you what it is, OBP after it or spelled out. Looks like this would say "with a .300 earned" 251 "The outstanding offensive player in the [%subleaguename] League has been picked" I've never seen 'League' after the [subleaguename] call? 829 "undoubtedly impressed with his [%batting rbi] runs driven and [%batting r] scored" Runs driven....... to the drive thru? 1943 "firsthand this year, today taking home the [%batteraward] in the [%subleagueabbr]" Cumbersome, "today" should probably move to the end of that sentence. 5115 "he rocketed [%batting h word] in [%batting ab] plate appearances" Say plate appearances but calls for his ABs 5116 "Overall this season he hit [%batting avg] and and numbered [%batting hr word] and [%batting d word] among his [%batting ebh word]."/>" Too many "and", 3 to be exact. The double, then the extra shortly after. 5124 "[%personlink] of the [%teamlink nick] had his swing down pat all season long barrage" "Barrage" doesn't fit. 5125 "berated enemt pitchers " Spelling: enemy 655 "also got an OBP of [%batting obp] through [%batting g] games" Shouldn't it be has an OBP? 1222 "He has tagged [%batting h word] with [%batting d] for doubles, [%batting t] for triples and [%batting hr word] for homers" "For"s don't belong. The next object after this says went for doubles... etc, this one tried the same it looks like but didn't reach it. Also I've noticed [batting hr word] usually doesn't put anything behind it. I would guess this is going to say 20 HRs for homers or something. 1230 "He has [%batting bb word] and struck out [%batting k word]" Another one like that. I've usually not seen any reference to what the [] mean unless the word "word" isn't in the [] call. So would this say struck out 20 Ks? 1257 "He has also chipped in with [%batting rbi word], [%batting r word] runs scored" Same as 1230. Would that say 20 Rs runs scored? 1259 "He has [%batting h word], stolen [%batting sb word] and scored " Sort of the same. Would that say stolen 20 SBs? 1268 "this year with [%batting hr word] and [%batting rbi word] RBIs." Sort of the same again. Would that say and 20 RBI RBIs? 1285 " he is batting [%batting avg]. He has bagged [%batting h word], [%batting d word] of which went for doubles" Same. Would that say 20 2B of which went for doubles? Obviously not certain (don't remember or haven't seen) how [... word] ends up appearing. 1233 "He has has scored [%batting r] times" Too many "has"s 1290 "[%personlink L] has also has swiped " "has also has" 1321 "stepped to the plate on [%batting ab] occasions " Talks like it should be PAs but calls ABs. No telling how long I could go on reading this. I get quite bored. Feel free to tell me to shut up if it's not helping. Also if I'm reading those calls wrong let me know, like the [... word] call. |
06-03-2006, 12:35 PM | #39 | |
Hall Of Famer
Join Date: Aug 2003
Posts: 4,925
|
Quote:
|
|
06-03-2006, 01:16 PM | #40 | |
Minors (Double A)
Join Date: Apr 2005
Posts: 121
|
Quote:
|
|
Bookmarks |
Thread Tools | |
|
|