The XML File Suggestion Thread

[Raidergoo]

Originally Posted by tysok

No telling how long I could go on reading this. I get quite bored. Feel free to tell me to shut up if it's not helping. Also if I'm reading those calls wrong let me know, like the [... word] call.

Please do. As you have seen, english.xml is a big file with a huge amount of text. The extra set of eyeballs does the game a world of good.

[RBLwebguy]

Originally Posted by tysok

Here's a couple I found, been searching through the actual XML page:

Format: TEXT OBJECT ID # - clip that contains the problem - what it is
11461
"rounds first...(nl)he'll bluff a throw(nl)and retreat to the bag"
He'll bluff a throw? I saw some where it says he tries to draw a throw... don't think anyone's gonna fall for the runner bluffing a throw, and where will he throw?

2268
2278
2279
2280
"He has chalked up [%batting h] all-time hits, 16 of which have gone for extra bases"
16 instead of a variable... some guys may have more or less EBH than others.

2272
2273
2275
2276
"His lifetime OBP is [%batting avg] with a [%batting slg] slugging percentage."
Looks like it's pulling up the battings average stat instead of the OBP stat for the OBP reference.

2277
"[%batting hr word] and rung up a lifetime .333 OBP with a [%batting slg] slugging percentage. "
.333 OBP instead of a variable.

2286
"He has also walked [%batting bb] time, stolen [%batting sb] bases and put up a [%batting obp] OBP"
Should be walked [] times.

2335
"A review of his career stats reveals he has played in [%batting g word], gone to the plate [%batting ab] times"
It's pulling up his number of AB but saying it's his PA.

2337
"stepped to the plate [%batting ab] times "
Same as 2335. These may be okay I guess, just wording leads to one thing but then the call goes for something else.

2577
"And he did it [%batting g] games"
Shouldn't it be "did it in [] games?

It's been fun reading these lines, one could probably play through many seasons and never see some of them. I've just scratched the surface of them too... think I've knocked off 7 pages so far...

I think a review of these batter career descriptions will be done shorty.

[RBLwebguy]

Originally Posted by tysok

Another set of problems I noticed.

1875
"[%playerposition] hit .333 and knocked in 102 runs, while scoring 5. He hit for power as well, collecting 16 extra-base hits with 12 of them going out of the park!"
Very consistent hitter, early in the season he'll have done really well but at some point he'll peak and never do better. Missing some variables.

5130
"These numbers, combined with a [%batting obp] earned him [%subleagueabbr] Batter of the Month honors"
Don't know if that's wrong. Usually this kind of call has something telling you what it is, OBP after it or spelled out. Looks like this would say "with a .300 earned"

251
"The outstanding offensive player in the [%subleaguename] League has been picked"
I've never seen 'League' after the [subleaguename] call?

829
"undoubtedly impressed with his [%batting rbi] runs driven and [%batting r] scored"
Runs driven....... to the drive thru?

1943
"firsthand this year, today taking home the [%batteraward] in the [%subleagueabbr]"
Cumbersome, "today" should probably move to the end of that sentence.

5115
"he rocketed [%batting h word] in [%batting ab] plate appearances"
Say plate appearances but calls for his ABs

5116
"Overall this season he hit [%batting avg] and and numbered [%batting hr word] and [%batting d word] among his [%batting ebh word]."/>"
Too many "and", 3 to be exact. The double, then the extra shortly after.

5124
"[%personlink] of the [%teamlink nick] had his swing down pat all season long barrage"
"Barrage" doesn't fit.

5125
"berated enemt pitchers "
Spelling: enemy

655
"also got an OBP of [%batting obp] through [%batting g] games"
Shouldn't it be has an OBP?

1222
"He has tagged [%batting h word] with [%batting d] for doubles, [%batting t] for triples and [%batting hr word] for homers"
"For"s don't belong. The next object after this says went for doubles... etc, this one tried the same it looks like but didn't reach it. Also I've noticed [batting hr word] usually doesn't put anything behind it. I would guess this is going to say 20 HRs for homers or something.

Fixed up to here

[AliG]

Not sure if this is the right thread but shouldn't there be some news stories about who wins the championships? I've found that whenever a team has won the title, a new story has never appeared to say it's all over and such and such won with Player X getting the MVP for the series.

Just thought that kinda thing would be a nice touch.

[redsox45]

This is the right place...

Markus is going to be adding more news stories in one of the upcoming patches they've got planned. Hopefully championsihps as well as career milestones will be on the list....

Will

[treedom]

Here's one:

the pitcher winds...
and fires...
batter takes a big cut...
driven on a line...
up the middle...
a tough play here...
and he's got it!
Wow, he robbed Anderson of a base hit there...

Who got it??

The play was scored in the game log as: Fly out, F6 (Line Drive, 6M)

[tysok]

6951
"he shows bunt...(nl)put pulls up and watches ball"
Should be "but pulls up"

6957
"squares to bunt...(nl)pulls it back...(nl)ball [%game balls+1 long](nl)he held up in time..."
Think you mean he pulled back in time, held up would be for a swing.

14102
14104
14105
"[%game catcher] throws down to first...(nl)it\'s in the dirt...(nl)[%game fielder2] can\'t pick it"
Don't know that this is a real problem, but most of these in this section reference [game firstbase] instead of [game fielder2]. As I read further it looks like this would come up fine the way it is though.

14107
"snaps a throw down to first...(nl)bad throw!(nl)It's in the dirt...(nl)[%game firstbase can't come up with it"
Looks like it's missing the end ] for [game firstbase]

12738
"know about that...(nl)the ump might\'ve missed that one!(nl)[%game strikes+1 long] "
Usually this reference would say "strike [game strikes...]"

12798
"[%game batter] tosses his helmut"
Helmet spelled wrong

In this section it says the Catcher appeals.... actually the catcher can only ask for an appeal. Really only the umpire appeals, and sometimes he refuses to appeal and makes his own call.

2365
"he has a [%pitching w]-[%pitching l] won-lost mark "
There's a bunch of these if this is a problem. Usually it's a won-loss mark instead of won-lost. Don't know that it really matters but...

2599
1204
1211
1218
"total appearances his lifetime won-loss record stands at [%pitching w word] and [%pitching l word]"
All these have the same "problem". Usually when it says won-loss record it doesn't have [word] in the brackers. Looks like this would say his won-loss record is 10 wins and 10 losses... repeating itself.

1182
1196
1197
1203
1208
1210
"so far this year with 30 saves out of "
All these list firm numbers instead of variables.

1205
"registered a [%pitching era] ERA and stuck out [%pitching k] in "
Should be struck instead of stuck

1212
1216
1217
"He has made [%pitching g] relief appearances "
Says relief appearances but calls for Games

1214
"In [%pitching g] appearances he has crafted a"
Just says appearances, but this is in that section of relievers so may be the same.

9987
"[%game pitcher] starts chirping at ump"
Should be chirps at the ump... unless the umpires name is ump.

10003
"discussing it face mask-to-face mask "
Could be fine... just looks weird.

14157
"[%game inning order long], [%game outs long] outs, [%game balls] and [%game strikes] the count"
Usually I see Inning [game inning]. Seems this might say Second, two outs....

14357
14375
"nice cut-off by [%game fielder]..."
This section usually references [game fielder of]. Don't know if it's a problem though.

[Raidergoo]

I sent 20+ corrections in based on that last post.

[RBLwebguy]

Originally Posted by treedom

Here's one:



Who got it??

The play was scored in the game log as: Fly out, F6 (Line Drive, 6M)

fixed

[RBLwebguy]

Originally Posted by Raidergoo

I sent 20+ corrections in based on that last post.

sent where?

[tysok]

There's 2 full categories that look like they're missing a word. Category 259 and 260.
Here's a couple clips from it:
"12536" text="here's a fly ball [%game flyball location]...(nl)nobody will get to it...(nl)it's a single..."/>
"12542" text="[%game batter] hits a single [%game flyball location]..."/>
"12572" text="here's a line drive...(nl)nobody will get to it, [%game batter] has a single [%game flyball location]..."/>

Looks like these need a "to" in front of [location]. There's a lot of them in those categories, some are right. If I'm reading it right this might say "here's a fly ball left field..." and "Johnson hits a single left field"
At least should have comma, but some in there are really off. A lot say "into [location] etc.... makes me think ones like these are wrong.

[AliG]

I signed this guy to a minor league contract and obviously he didn't sign for "0" years as the report says.

[tysok]

Originally Posted by AliG

I signed this guy to a minor league contract and obviously he didn't sign for "0" years as the report says.

Did he really sign or is that his idea of humor and sarcasm?

[Raidergoo]

Originally Posted by RBLwebguy

sent where?

TT#1633

[Raidergoo]

Originally Posted by tysok

Did he really sign or is that his idea of humor and sarcasm?

known issue with minor league contracts

[RBLwebguy]

Originally Posted by Raidergoo

TT#1633

I can fix the XML stuff using an online editor, so we only need to TT stuff that is hardcoded

[Markmeister]

Mispelled word - should be breaks

id="3767" text="[%personname L] Breks Out with Career-Defining Barrage; Smacks 3 Dingers"

[Raidergoo]

Originally Posted by RBLwebguy

I can fix the XML stuff using an online editor, so we only need to TT stuff that is hardcoded

Awesome!

[Raidergoo]

Someone elsewhere pointed out logner

it is in 4237.

[tysok]

264
267
269
270
"Good fielders are honored by the [%subleaguename] League: (nl)(nl)[%string]"
I don't usually see "League" after [subleaguename]

1435
"[%defenseaward] are the symbol for defensive"
Should it be [defenseaward is the symbol? Or [defenseaward] plural.

1440
1441
"The elite glovemen in [%subleaguename] are: (nl)(nl)[%string]"
Should be the [subleague]

1443
"obscure awards in baseball, [%defenseaward] was presented today to:"
Should be "the [defenseaward]

4750
4751
"The [%subleaguename] finest defenders, the [%defenseaward] winners "
Should be poossessive [subleage]'s

4754
"backhand stop or an umbelievable over-the-shoulder catch"
Spelling, Unbelievable instead of umbelievable

4756
"honored at this year\'s annual SION sports awards banquet. [%defenseaward] will be presented to these top notch"
Should be "the [defenseaward]" or pluralize it.

4757
"The vast vaccum of space "
Spelling, vacuum instead of vaccum

148
150
"[%subleaguename] Selects the Best of the Best Fielders--[%defenseaward] Award Winners Announced for this Season"
Should be "The [subleaguename]"

151
"[%subleagueabbr] Honors Players Outstanding Fielders: [%defenseaward] Awards Presented for this Year"
The [subleague] again.... also "Players" doesn't fit, unless you change fielders to fielding

12404
"and hestill came away with the ball"
Spelling, "he still" not hestill

12362
"AND MAKES THE CATCH!(nl)how about that, folks!"
Should be capital H in "how"

14257
"that\'s one for [%game fielder], who is on the move"/>"
The announcer should really know who's on the move, I'm not there to see it. Maybe "He is on the move"

14685
14686
14687
"a few steps and Davis camps under it..."
Davis instead of variable - think this was already found, but might as well be thorough.

14301
"infield rule called"
Infield fly rule called

12213
"to [%game flyball depth]"
But to which field? "to shallow" or "to deep"

11855
"[%game pitcher] pops him up..."
Sounds like the pitcher has swung mightily and popped up the batter. Was he charging the mound?

12563
"[%game flyball location]...(nl)for a base hit(nl)[%game batter] pulls up at first"
What happened in flyball location? Almost looks like "hit the ball" will come first, but the rest of the objects in this area don't follow that pattern.

12609
"starts in...(nl)stops and start...(nl)and fields it on a high hop"
Letter missing, Stops and starts

13922
"no chance to catch it...(nl)it\'s lands five or six rows in."
It's lands five isn't quite right.

13923
"it a little pop fly right behind the plate"
It's a little pop...

14829
"Swinging a Hot Bat, [%personname L] Has Five Hits Against [%team#2nickname] Pitching"
Five instead of variable. I think this is the 5 hits in a game section, but even so, what if he had 6 hits?

14854
"[%personlink l] has [%batting h] en route to hitting for the cycle"
Should be got [hits] en route

14855
"He hit for the cycle, collecting a single, double, triple and home run."
Shouldn't these be variables?

14719
"[%teamplayer nolink] [%personname f l] "
Never seen [%teamplayer no link] called before... don't know if it's right or not but thought I'd mention it.

14889
"For [%team#1link nickname] starter [%personlink], that moment happened today when they threw a perfect game against [%team#2link]"
Unless the pitcher is the king of England, it should be "when he threw a perfect"

14890
"[%pitching k] [%team#2link] hitters struck out against [%personlink l] who showed some of the best control of their career"
Another king. Should be "control of his career"

14897
"[%personlink] was unhittable and unforgetable today. "
Spelling, unforgettable

4818
"[%personlink] discovered that when he launched three longballs into the stands during the course of a one game against the [%team#2link nickname]. "
Should drop "a" or "one", "during the course of one (or a) game"

4833
"The [%team#1link] [%playerposition] was red hot, the ball just exploding off his bat all day long. "
Should be exploded?

4837
"launching three pitches over the wall giving him a total of 14 home runs on the season"
14 instead of variable

4838
"against [%team#2link] today ensuring himself of at least one day of fame in this young career"
Shouldn't it be "in his young career"?

4840
"No creaky bones in the veteran [%personlink], demonstrating he still has what it takes to get attention rocketing three balls out of the park "
Being nitpicky here, but it doesn't read right. Should be a period instead of comma, and start new with Demonstrating, and "he rocketed" instead of rocketing. So it would be:
"No creaky bones in the veteran [personlink]. Demonstrating he stiall has what it takes to get attention, he rocketed three balls out of the park..."

4841
"It doesn\'t happen very often, but when it does you want write down the name"
You want to write it down

3767
"[%personname L] Breks Out with Career-Defining Barrage; Smacks 3 Dingers"
Markmeister beat me to the misspelling, but it should also be "a Career defining"