Historical database issues go here!

[LansdowneSt]

smithbi02 has the wrong minor league code. This (smithbi02) Bill Smith played for Cleveland in 1884 and died tragically a year later. His minor league ID ought to be "smith-007bil" per Baseball-Reference. The Minor League code in OOTP currently is "smith-254---" which should instead ties to a Class B relief pitcher for Johnstown in 1892 in BRef.

Thanks!

[LansdowneSt]

pratt-001cre should be African-American. Thanks.

[omniart]

Tommy De La Cruz (Cincinnati Reds, 1944) does not import when doing a historical replay. His bbref_id is dela_to01, and his lahman_id is delacto01. OOTP does not recognize these. It does recognize delato01 without the underscore.

[Lukas Berger]

Originally Posted by omniart

Tommy De La Cruz (Cincinnati Reds, 1944) does not import when doing a historical replay. His bbref_id is dela_to01, and his lahman_id is delacto01. OOTP does not recognize these. It does recognize delato01 without the underscore.

We don't necessarily always use the exact same id as B-Ref. So this is not really a bug.

In this case, I think the underscore messes with things, and so we have to leave that out, but not 100% sure on that.

But if he's not importing at all, it may be there's some sort of id mismatch, so will check on that.

[omniart]

Originally Posted by Lukas Berger

But if he's not importing at all, it may be there's some sort of id mismatch, so will check on that.

This.


Perhaps I wasn't clear. De La Cruz does not import automatically when running a Historic Game. He can be imported individually using the id delato01. I assume that there is an id mismatch and that the OOTP Historic Game engine tries to import him using either the dela_to01 or delacto01 id.

[scarter95]

Originally Posted by pstrickert

Fixed Lolich.

Thank you!

[LansdowneSt]

Former MLB'er and Phillies manager, Charlie Manuel, comes in as Hispanic but I think someone just assumed that from his last name. While I don't know his full family tree, I don't think he ought to be.

https://www.baseball-reference.com/m...anuech01.shtml

https://sabr.org/bioproj/person/charlie-manuel/

[scarter95]

Because we're all baseball geeks here, was curious to play a seven-game series between the 2007 Yankees and 1993 Rangers to see how 46-year-old Nolan Ryan and 44-year-old Roger Clemens would fare taking turns in series.

I noticed that Clemens is not listed in 2007 Yankees roster. He was there until end, and pitched in playoffs that season.

Just an FYI

[LansdowneSt]

It may be using beginning-of-season rosters as opposed to end-of-season rosters. As a Sox fan, I remember him choosing to sign in May with the Yanks that year.

[scarter95]

Originally Posted by LansdowneSt

It may be using beginning-of-season rosters as opposed to end-of-season rosters. As a Sox fan, I remember him choosing to sign in May with the Yanks that year.

Good point. I'll check and see if he shows up on either end- or start-of-season roster.

[LansdowneSt]

Baseball Reference has corrected two weights for players (it's impacting the fg's I create) and they need to be corrected in OOTP. If you use uploads from bRef, it may correct on its own for OOTP23 but a double-check to ensure they are corrected would help. The players are:

Sammy Sosa (sosasa01) corrected from 220lbs to 165lbs

Davis Washington (washida01) corrected from 260lbs to 230lbs.

Thanks

[Lukas Berger]

Originally Posted by LansdowneSt

Baseball Reference has corrected two weights for players (it's impacting the fg's I create) and they need to be corrected in OOTP. If you use uploads from bRef, it may correct on its own for OOTP23 but a double-check to ensure they are corrected would help. The players are:

Sammy Sosa (sosasa01) corrected from 220lbs to 165lbs

Davis Washington (washida01) corrected from 260lbs to 230lbs.

Thanks

We'd need to change this manually, nothing is automated.

That being said, there is no way in the world Sammy Sosa weighed 165 pounds anywhere near his peak. 220 I can believe. Soooo, not sure what to do about that one...

[LansdowneSt]

If you have discretion for gameplay purposes, I'd recommend no more than 210 for Sammy. I've run the fg at various weights and there is some difference in its appearance at 200, 210 ... but at 220lbs... it's a big difference. As if the game hits an fg tipping point where an fg becomes impossible to make look like him. Here's 210 lbs vs. 220 lbs. The 210 one looks much more akin to the 165lb one, honestly. If I could advocate for those of us working the facegen thread, just that 10lbs makes a world of difference in the jowls and head width. No adjustment to the fg itself can counter the current in-game weight added from the 220lb setting.

That's 210lbs on the left (or above depending on browser width) and 220lbs on the right (or below)

As for the 230lbs for Dave Washington, he's still playing so in the email exchange w/bRef that's how they settled that one. Still heavy but less than the 260lbs. Talk about tipping point on an fg....

Thanks for considering, Lukas!

[LansdowneSt]

Don Hopkins - one of the many pinch runners of Finley's Swingin' Oakland A's - is incorrectly listed as Caucasian. Should be African-American.

hopkido01

https://www.baseball-reference.com/p...opkido01.shtml

[LansdowneSt]

Seung-hwan Oh's Historical Minors ID changed in the last update. It no longer matches the bRef one. I know not all do but it is unusual for it to change away from it. It also looks like a plain ol' typo... (AtACO?)

I noticed it because my facegen stopped coming through all of a sudden.

[Lukas Berger]

Originally Posted by LansdowneSt

Seung-hwan Oh's Historical Minors ID changed in the last update. It no longer matches the bRef one. I know not all do but it is unusual for it to change away from it. It also looks like a plain ol' typo... (AtACO?)

I noticed it because my facegen stopped coming through all of a sudden.

The issue with the historical minors ids (it affected a bunch more than just Oh) actually cropped up a while ago, but should've been fixed in one of the last patches. Are you sure you're up to date on the patches?

[LansdowneSt]

Yes, assuming it is 22.12 Build 86. Just imported Oh again to see if it was just my already existing in-game Oh that missed the update... but Oh still has the error when importing him clean in 22.12.86. If there is another name from the list of ones that were impacted, I can check those too. Did Oh some in corrected for you on a historical.database import? I pulled him in from 2016.

[Lukas Berger]

Originally Posted by LansdowneSt

Yes, assuming it is 22.12 Build 86. Just imported Oh again to see if it was just my already existing in-game Oh that missed the update... but Oh still has the error when importing him clean in 22.12.86. If there is another name from the list of ones that were impacted, I can check those too. Did Oh some in corrected for you on a historical.database import? I pulled him in from 2016.

It looks like Oh and a couple of other guys (Fu-Te Ni, Chin-Lung Hu, and Chin-Lung Hu for reference's sake) did indeed have issues with their minors id's still. I fixed that in the db now, but that won't necessarily show up until OOTP23, unless we have another patch this year, which we're not planning on.

So the workaround for the moment would be to just make a copy of the facegen and name it with the wrong id.

Sorry about that

[LansdowneSt]

No worries, Lukas. Thanks for looking into it. I'll keep the fg named as is and just change the id back to what it should be via the game editor. Last thing I need is a soon-to-be-obsolete fg littering the facegen pack. OOTP23 is fine. I'll be here for it

[actionjackson]

Originally Posted by LansdowneSt

Lukas,

Here's one for you with regard to the "Historical Minors ID" for Eddie Bane - and hopefully just him. It's different if you look him up in a current game as a retired player versus importing him. The thread the issue is on with pictures is here:

https://forums.ootpdevelopments.com/...=330868&page=2

Thanks for all the great work - and yes, my Greg Minton issue was with OOTP21 - glad he was shrunk for OOTP22

The issue there was in the Master. He was given two nicknames with a comma between them. Since the Master's a csv file, this shunted everything on his line to the right, so Moonie was in his NickName column, Moon-man was in his weight column, his weight (190) was in his height column, which would make him 15'10". His height (74) was in his Bats column, his switch hitting capabilities moved into his Pitches column, creating another Venditte, and on, and on. The 22 Master looks much better from this standpoint.