Historical database issues go here

[niu354]

The database has a handful of early 20th century players with first names that you really don't want appearing in the game. These guys have real first names that you could easily use instead. List in the link below.

https://en.wikipedia.org/wiki/Nig_(nickname)

[Lukas Berger]

Originally Posted by niu354

The database has a handful of early 20th century players with first names that you really don't want appearing in the game. These guys have real first names that you could easily use instead. List in the link below.

https://en.wikipedia.org/wiki/Nig_(nickname)

We'd fixed most of these up, but looks like two were left. Fixed them both now.

[dewelar]

I'm sure this is going to get fixed at some point, but since it's a fairly prominent current player...

Rob Refsnyder is listed correctly as being born in Seoul, but the country is listed as the US instead of South Korea.

[LansdowneSt]

Originally Posted by dewelar

I'm sure this is going to get fixed at some point, but since it's a fairly prominent current player...

Rob Refsnyder is listed correctly as being born in Seoul, but the country is listed as the US instead of South Korea.

It's actually correct in the db as Seoul, South Korea as a city of birth. The US flag means he is given primary US nationality and a secondary ROK nationality. Per wikipedia: "Refsnyder was born in Seoul, South Korea, and was adopted by a couple from Southern California when he was five months old." I have no idea which he would regard as "primary" but he is shown in-game as a dual-citizen, which mostly matters for WBC kinda stuff.

[dewelar]

That's odd, because when I open up Master.csv in Excel from the recently posted patch, it shows "The United States" in the birthCountry field with "Seoul" in both birthCounty and birthCity. Importing him into an existing game in OOTP26 shows him with Nationality American and no Second Nationality with a blank City of Birth. This is all in Build 70.

[LansdowneSt]

Originally Posted by dewelar

That's odd, because when I open up Master.csv in Excel from the recently posted patch, it shows "The United States" in the birthCountry field with "Seoul" in both birthCounty and birthCity. Importing him into an existing game in OOTP26 shows him with Nationality American and no Second Nationality with a blank City of Birth. This is all in Build 70.

It is because "birth country" isn't actually a field. It's all tied to together when you select the city from the available options. The output for that column is likely "Nationality". Surprised the 2nd nationality doesn't show though. It's easy enough to reverse them if that allows both nationalities to show.

I can reverse them and see if it likes that better. The most important things is that he gets eligibility for leagues/teams with both of those nations. I'll dig into it after work

[Carplos]

fwiw, in a standard game has the second nationality as South Korea, but the city of birth is still unknown

Maybe cause it's Seoul and his first nationality is US?

[LansdowneSt]

Originally Posted by Carplos

fwiw, in a standard game has the second nationality as South Korea, but the city of birth is still unknown

Maybe cause it's Seoul and his first nationality is US?

I can flip them. That should align it,

[AESP_pres]

Not the biggest deal but Pretzels Getzien is listed as Pretzels Getzein in the game... just a small typo. id is getzie001pre

[LansdowneSt]

Originally Posted by AESP_pres

Not the biggest deal but Pretzels Getzien is listed as Pretzels Getzein in the game... just a small typo. id is getzie001pre

fixed

[Caridnals-BK]

Originally Posted by LansdowneSt

The fake pitching lines are especially problematic because they are in minor leaguers AND MLB'ers. Even as I do audits (like on-going city of birth fixes, year of birth fixes, height, weight, etc.) I generally limit myself to AL/NL and NeL.

There is a pattern to those P lines though and they are obvious once you start looking for them. We are getting to the point (once I have some other projects behind me), that I could take the MiLB and its huge csv, resort by Historic Minors ID then year, take a certain number of rows at a time and let the AI tell me who looks suspect based on the repetitive pattern of those lines and then I save the search time and only burn my OOTP help time with targeted deletions to identified lines.

For now, they generally don't cause to much harm hence it is a project. But every but helps on a db as massive as this one is.

Is it helpful to continue to provide a list of players with the fake stats? There are a boatload of them and I don't want to overload. I know I prefer to see accurate stats for a player, and the odd middle infielder that turns into a relief pitcher is a little weird.

[LansdowneSt]

Originally Posted by Caridnals-BK

Is it helpful to continue to provide a list of players with the fake stats? There are a boatload of them and I don't want to overload. I know I prefer to see accurate stats for a player, and the odd middle infielder that turns into a relief pitcher is a little weird.

At some point I will feed the MiLB pitching stat csv bit by bit in GPT and have it identify suspect lines and return the Historical Minors IDs. It is the finding of them (boatloads though there may be) that is work in addition to the physical time in the db cleaning it up. For now, maybe give me five at a time and when you get a "fixed" reply, drop five more. We'll both get to it as our time permits that way. Every one gone is a win, after all.

[Caridnals-BK]

Originally Posted by LansdowneSt

At some point I will feed the MiLB pitching stat csv bit by bit in GPT and have it identify suspect lines and return the Historical Minors IDs. It is the finding of them (boatloads though there may be) that is work in addition to the physical time in the db cleaning it up. For now, maybe give me five at a time and when you get a "fixed" reply, drop five more. We'll both get to it as our time permits that way. Every one gone is a win, after all.

Thanks! I started an '86 with the Cardinals and found about 20 players. I hope these help.

Jose Rodriguez – rodrig024jos – Real: 86 Arkansas; Fake: 80-85; 86 Springfield
Reed Olmstead – olmste001ree – Real: 96; Fake: 86-91 – also missing '97 Independent season
Claude Patton – patton001cla – 1986 - missing 1B and OF fielding stats
Mike LaValliere – lavalmi01 – Real: 83 and 84 Reading; fake: 81-82, 84 Portland, 85, 89, 93, and 95
Sal Agostinelli – agosti001sal – Real: 88 Louisville (ip off by .2), 91 Scranton; Fake: 83-87, 88 Arkansas, 90-92 except 91 Scranton