possible bug in Cato

Go Tribe · 07-07-2004, 05:47 PM

Cato,

We're still using ootp5 at www.hblbaseball.com and noticed that on one of our award pages, Eddie Hernandez is shown as winning the AL Fireman of the Year (which is correct) however his team shows as the San Diego Padres

http://www.hblbaseball.com/reference.../alawards.html

Eddie was traded from the Padres to the Tigers in June of that year.

Now i went into the database that your program creates and looked at the Pitching Table and the qrySPitYearTot query. The problem is that you have player ID, year and team as primary keys - while that in itself is not a problem, it does mean that data is sorted in that order. So Eddie's 2010 line with Detroit comes BEFORE his 2010 line of data with the Padres (since DET comes before SDG alphabetically). Your qrySPitYearTot query looks at the LAST line of data for each player each year and assigns that as the player's final team. So in that query, Eddie's final team is showing as SD not Detroit and thus the award screen shows SD as his team on the AL Awards screen.

The guy in charge of the ref pages went through every trade from 2007 to 2011 and found 44 total guys that were in there wrong because of this - always when the players last team of the year is listed alphabetically in front of his first team.

I doubt you are putting in updates to the old cato program but wanted to make you aware of this in case it's also happening in v6.

As you can also see, it messes up a player's split stats on the individual player pages http://www.hblbaseball.com/reference...neddie276.html

(they are out of order)

thanks

jcato · 07-07-2004, 09:06 PM

Well, I'd say it's more of an omission than a bug. I have never attempted to order the stats, just split them. I can see why its a problem, though. I'll try to come up with some kind of fix. I know the Lahman db uses a stintID field now that orders the teams. Maybe I can add that column to the tables. It won't help whats already in the database, but it could fix it going forward.

07-07-2004, 05:47 PM	#1
Go Tribe All Star Starter Join Date: Dec 2001 Posts: 1,534 Infractions: 1/0 (0)	possible bug in Cato Cato, We're still using ootp5 at www.hblbaseball.com and noticed that on one of our award pages, Eddie Hernandez is shown as winning the AL Fireman of the Year (which is correct) however his team shows as the San Diego Padres http://www.hblbaseball.com/reference.../alawards.html Eddie was traded from the Padres to the Tigers in June of that year. Now i went into the database that your program creates and looked at the Pitching Table and the qrySPitYearTot query. The problem is that you have player ID, year and team as primary keys - while that in itself is not a problem, it does mean that data is sorted in that order. So Eddie's 2010 line with Detroit comes BEFORE his 2010 line of data with the Padres (since DET comes before SDG alphabetically). Your qrySPitYearTot query looks at the LAST line of data for each player each year and assigns that as the player's final team. So in that query, Eddie's final team is showing as SD not Detroit and thus the award screen shows SD as his team on the AL Awards screen. The guy in charge of the ref pages went through every trade from 2007 to 2011 and found 44 total guys that were in there wrong because of this - always when the players last team of the year is listed alphabetically in front of his first team. I doubt you are putting in updates to the old cato program but wanted to make you aware of this in case it's also happening in v6. As you can also see, it messes up a player's split stats on the individual player pages http://www.hblbaseball.com/reference...neddie276.html (they are out of order) thanks

07-07-2004, 09:06 PM	#2
jcato Minors (Triple A) Join Date: Jan 2004 Posts: 200	Well, I'd say it's more of an omission than a bug. I have never attempted to order the stats, just split them. I can see why its a problem, though. I'll try to come up with some kind of fix. I know the Lahman db uses a stintID field now that orders the teams. Maybe I can add that column to the tables. It won't help whats already in the database, but it could fix it going forward.