Extra Innings Game not ending at bottom of inning when scores not level

Tony M · 06-14-2007, 10:11 AM

This is just a bug brought around by having silly ratings for players, but a bug none the less.

The game summary record has an innings field which is a byte, and thus can only store up to 255.

Thus when a game goes to the 256th inning it rollsover and starts at 0.

Because of this, if a unanswered run is scored in innings 256-263 it doesn't end the game as it thinks it's still in the first 9 innings of the match. I would have thought the game would have set an Extra-Innings flag rather than rely on the innings count.

This game was around 200 innings longer than any that had been done before using these settings and I only noticed it when I saw the box score going to 9 innings and the teams having managed 67 hits between them which I thought was impressive given that only 1 run had been scored.

Oakland had scored in the top of the 260th inning and The Bronx did not reply so the game should have ended there, but it went on to the 265th inning...

The game lasted a staggering 56:54... I wish I'd checked on the fatigue status of the players after that.

Nutlaw · 06-14-2007, 11:49 AM

Alright, I logged this one as TT 3699, but this is stretching things. The game allows you a broad range of customization, but you really can't expect it to be able to function properly when giving it such absurd settings.

Tony M · 06-14-2007, 12:07 PM

Fair enough nutlaw. I don't know if this is something that can be added to the forum - a sort of priority field, because I would have set this one very low, as it's just an error in the way the end of the game is calculated and it does require it to have reached 256-265 or 512-521 etc innings.

There is a separate bug when a game reaches its 40th innings in that the box score starts to display wrong values.

Well, not wrong values, just further on bits from the world.dat record. There is a hard coded structure limit of 39 innings and if the innings count is > 39 the box score just keeps outputting as many bytes as it needs from the database. So if a game goes to 43 innings the 40th-43rd inning for the away team is actually the Starting Pitcher ID for the home team in big-endian order (40th + (41st * 256) + (42nd * 65536) + (43rd * 16777216?)).

At the 50th inning for the away team you'll start to see the home team inning scores starting at the 1st appearing for the away team.

This is probably a design update for 2008 because having 39 innings per team per match as a fixed limit uses up more space than having a variable structure. The match summary record already contains the innings count so this could be used to determine how many bytes to read for box scores.

Given most matches end in 9, there is 60 bytes of unused space in each match record, and a traditional MLB setup has something like 14,000 matches, that comes to almost a megabyte in un-utilised space.

Nutlaw · 06-14-2007, 12:41 PM

TT 3700. Please list separate issues in separate threads. It's easier to keep track of them that way.

Nutlaw · 07-09-2007, 07:15 PM

This TT was listed for consideration in a future release of the game.

06-14-2007, 10:11 AM	#1
Tony M Global Moderator Join Date: Feb 2006 Location: Here Posts: 6,156	Extra Innings Game not ending at bottom of inning when scores not level This is just a bug brought around by having silly ratings for players, but a bug none the less. The game summary record has an innings field which is a byte, and thus can only store up to 255. Thus when a game goes to the 256th inning it rollsover and starts at 0. Because of this, if a unanswered run is scored in innings 256-263 it doesn't end the game as it thinks it's still in the first 9 innings of the match. I would have thought the game would have set an Extra-Innings flag rather than rely on the innings count. This game was around 200 innings longer than any that had been done before using these settings and I only noticed it when I saw the box score going to 9 innings and the teams having managed 67 hits between them which I thought was impressive given that only 1 run had been scored. Oakland had scored in the top of the 260th inning and The Bronx did not reply so the game should have ended there, but it went on to the 265th inning... The game lasted a staggering 56:54... I wish I'd checked on the fatigue status of the players after that.

06-14-2007, 11:49 AM	#2
Nutlaw Hall Of Famer Join Date: Apr 2003 Posts: 9,538	Alright, I logged this one as TT 3699, but this is stretching things. The game allows you a broad range of customization, but you really can't expect it to be able to function properly when giving it such absurd settings.

06-14-2007, 12:07 PM	#3
Tony M Global Moderator Join Date: Feb 2006 Location: Here Posts: 6,156	Fair enough nutlaw. I don't know if this is something that can be added to the forum - a sort of priority field, because I would have set this one very low, as it's just an error in the way the end of the game is calculated and it does require it to have reached 256-265 or 512-521 etc innings. There is a separate bug when a game reaches its 40th innings in that the box score starts to display wrong values. Well, not wrong values, just further on bits from the world.dat record. There is a hard coded structure limit of 39 innings and if the innings count is > 39 the box score just keeps outputting as many bytes as it needs from the database. So if a game goes to 43 innings the 40th-43rd inning for the away team is actually the Starting Pitcher ID for the home team in big-endian order (40th + (41st * 256) + (42nd * 65536) + (43rd * 16777216?)). At the 50th inning for the away team you'll start to see the home team inning scores starting at the 1st appearing for the away team. This is probably a design update for 2008 because having 39 innings per team per match as a fixed limit uses up more space than having a variable structure. The match summary record already contains the innings count so this could be used to determine how many bytes to read for box scores. Given most matches end in 9, there is 60 bytes of unused space in each match record, and a traditional MLB setup has something like 14,000 matches, that comes to almost a megabyte in un-utilised space.

06-14-2007, 12:41 PM	#4
Nutlaw Hall Of Famer Join Date: Apr 2003 Posts: 9,538	TT 3700. Please list separate issues in separate threads. It's easier to keep track of them that way.

07-09-2007, 07:15 PM	#5
Nutlaw Hall Of Famer Join Date: Apr 2003 Posts: 9,538	This TT was listed for consideration in a future release of the game.