Catobase - Renaming Teams...

SandMan · 12-07-2005, 09:28 AM

Okay...I found a big bug in CATOBASE and searched some other leagues and this is not a problem with the new version of OOTP but apparently has been around for some time.... The problem is simple if you rename the teams, either at the league creation screen or in the team setup page then when catobase runs the team that is last in the list alphabetically does not get the process the player draft history. I new it did this with the team editor but did not realize catobase does this also. This is a problem with the way the program sets the arrays to process the draft list.

Bad news is there is no easy fix for this. You need to enter the draft choices into the access tables manually from the team draft history and then would need to do it each year after this.

This problem does not occur if you have not renamed the teams because the indexing does not change. I verified that this was a problem with past seasons also. I caught this because I just started a Midwest States League and I was the gm of WISCONSIN, just happended to be the last team in the alphabetical list.... I verified this by rerunning the league's first season 5 times and got the same error, I then created a league without renaming the teams and found no problems, I then changed one of the teams to be the last in the list alphabetically and was able to duplicate the problem....

Bottom line - Either don't use catobase if you rename your teams, or if you don't mind not having the draft list by the last team in the league then you can run it. This does not affect any leagues where the teams are not rename and this only occurs when renaming the City Location and not the team nickname..... To me this caused me to delete the league because I did want to have the draft history of my team.....

Indexing tables and arrays and the errors that it causes when not reading the last record is one of the first things they teach you as a programmer to check for in testing. I just could not believe that this was not caught before now. I guess I never really looked at the draft lists before and tied it in with the last team in the list. This problem had been reported previously and was one that I did not know the solution for other than to manually add the records each season. Now we know the cause, but this really sucks.......

Jestor · 12-08-2005, 01:10 AM

But what if the team being renamed doesn't cause a change in who the last team is? Does the error still kick in then?

SandMan · 12-08-2005, 08:00 AM

Quote:

Originally Posted by Jestor

But what if the team being renamed doesn't cause a change in who the last team is? Does the error still kick in then?

Only the last team is affected. But I will run another test.

f.montoya · 12-08-2005, 08:18 AM

Excellent work SandMan! I'm compiling a "SandMan troubleshooting" list that I will add to the tutorial site which will include a more detailed list of what causes errors(and wether or not they can be fixed easily or not). While finding problems isn't positive, finding their cause is, and will serve as a warning regardless.

ctorg · 12-08-2005, 09:22 AM

Nice find. Thankfully, I never really look at the draft history, so it's no big deal to me.

gcsii99 · 12-08-2005, 09:47 AM

Quote:

Originally Posted by SandMan

Okay...I found a big bug in CATOBASE and searched some other leagues and this is not a problem with the new version of OOTP but apparently has been around for some time....

Is this saying that the problem is in Catobase, or that its not an issue if you are using "the new version of OOTP" (presumably 6.51)?

marky32082 · 12-08-2005, 11:37 AM

Coincidentally I had this same error ina league I have when I move the Milwaukee Brewers to Berlin. Are we sure it's not an issue with the state of Wisconsin in general?

I ended up manually changing the draft history I think. It was a while ago though so I'm not sure if I ever fixed it.

Let's just hope that Catobase2006 fixes all these problems!

SandMan · 12-08-2005, 03:48 PM

This problem happens in all versions of OOTP regardless of the fixes put out by Markus. And this only happens when you manually change a name of a team either in the league setup or the team setup...... Thiis sucks but hopefully the next version of catobase will use the files I suggested 2 years ago. DRAFTLOG.txt and the team history files instead of reading through all the players histories...

I have also found another bug but at this time I am doing some more testing and working on a workaround. At the time I solve what causes the bug I will post more info on it.....

12-07-2005, 09:28 AM	#1
SandMan Hall Of Famer Join Date: Aug 2003 Posts: 2,946	Catobase - Renaming Teams... Okay...I found a big bug in CATOBASE and searched some other leagues and this is not a problem with the new version of OOTP but apparently has been around for some time.... The problem is simple if you rename the teams, either at the league creation screen or in the team setup page then when catobase runs the team that is last in the list alphabetically does not get the process the player draft history. I new it did this with the team editor but did not realize catobase does this also. This is a problem with the way the program sets the arrays to process the draft list. Bad news is there is no easy fix for this. You need to enter the draft choices into the access tables manually from the team draft history and then would need to do it each year after this. This problem does not occur if you have not renamed the teams because the indexing does not change. I verified that this was a problem with past seasons also. I caught this because I just started a Midwest States League and I was the gm of WISCONSIN, just happended to be the last team in the alphabetical list.... I verified this by rerunning the league's first season 5 times and got the same error, I then created a league without renaming the teams and found no problems, I then changed one of the teams to be the last in the list alphabetically and was able to duplicate the problem.... Bottom line - Either don't use catobase if you rename your teams, or if you don't mind not having the draft list by the last team in the league then you can run it. This does not affect any leagues where the teams are not rename and this only occurs when renaming the City Location and not the team nickname..... To me this caused me to delete the league because I did want to have the draft history of my team..... Indexing tables and arrays and the errors that it causes when not reading the last record is one of the first things they teach you as a programmer to check for in testing. I just could not believe that this was not caught before now. I guess I never really looked at the draft lists before and tied it in with the last team in the list. This problem had been reported previously and was one that I did not know the solution for other than to manually add the records each season. Now we know the cause, but this really sucks.......

12-08-2005, 08:18 AM	#4
f.montoya Hall Of Famer Join Date: Nov 2004 Posts: 6,069	Excellent work SandMan! I'm compiling a "SandMan troubleshooting" list that I will add to the tutorial site which will include a more detailed list of what causes errors(and wether or not they can be fixed easily or not). While finding problems isn't positive, finding their cause is, and will serve as a warning regardless. __________________ Fidel Montoya Asahi2 Baseball ex-Commissioner(Historical League Since 2004) www.allsimbaseball.com (OOTP web hosting - Customized sites for online leagues - Sign up, Connect OOTP and Play!) Share Your Mods - Free, unlimited and easy to upload to share your Mods instantly(free site registration required)

12-08-2005, 09:22 AM	#5
ctorg Global Moderator Join Date: Nov 2002 Location: Queens, NY Posts: 9,848	Nice find. Thankfully, I never really look at the draft history, so it's no big deal to me. __________________ My music "When the trees blow back and forth, that's what makes the wind." - Steven Wright Fjord emena pancreas thorax fornicate marmalade morpheme proteolysis smaxa cabana offal srue vitriol grope hallelujah lentils

12-08-2005, 11:37 AM	#7
marky32082 Minors (Triple A) Join Date: Jun 2004 Location: Chicago Posts: 283	Coincidentally I had this same error ina league I have when I move the Milwaukee Brewers to Berlin. Are we sure it's not an issue with the state of Wisconsin in general? I ended up manually changing the draft history I think. It was a while ago though so I'm not sure if I ever fixed it. Let's just hope that Catobase2006 fixes all these problems! __________________ These pretzels are making me thirsty!

12-08-2005, 03:48 PM	#8
SandMan Hall Of Famer Join Date: Aug 2003 Posts: 2,946	This problem happens in all versions of OOTP regardless of the fixes put out by Markus. And this only happens when you manually change a name of a team either in the league setup or the team setup...... Thiis sucks but hopefully the next version of catobase will use the files I suggested 2 years ago. DRAFTLOG.txt and the team history files instead of reading through all the players histories... I have also found another bug but at this time I am doing some more testing and working on a workaround. At the time I solve what causes the bug I will post more info on it.....